You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Richard Taylor (JIRA)" <ji...@apache.org> on 2007/10/25 00:57:50 UTC
[jira] Created: (ODE-204) Properly remove process from map of
registered processes in BpelServerImpl.java (and some logging consistency)
Properly remove process from map of registered processes in BpelServerImpl.java (and some logging consistency)
--------------------------------------------------------------------------------------------------------------
Key: ODE-204
URL: https://issues.apache.org/jira/browse/ODE-204
Project: ODE
Issue Type: Bug
Components: Axis2 Integration
Affects Versions: 1.1
Environment: ODE 1.1
Axis2 Distro
JDK 1.5.0_10
Jetty 6.1.1
Reporter: Richard Taylor
Priority: Trivial
Fix For: 1.1.1, 1.2
First item:
Wanted to add consistency to the logging messages when deploying a new process
1. When deploying, the term "Activated" is used. However when undeploying, the term "Unregistered" is used.
2. When deploying a new process, the log says "Process foo-1 has been unregistered", even if a no previous versions of foo were deployed. This was due to accidentally putting the log call outside of a conditional
Second item:
I haven't seen any direct affects from this code, but it is a bit off. "p" is never assigned a value before being referenced. From
BpelServerImpl.java:
------------------------------------
BpelProcess p = null;
if (_engine != null) {
_engine.unregisterProcess(pid);
_registeredProcesses.remove(p);
}
Seems it should be something like this:
------------------------------------
BpelProcess p = null;
if (_engine != null) {
p = _engine.unregisterProcess(pid);
if (p != null)
{
_registeredProcesses.remove(p);
}
}
A patch will be attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-204) Properly remove process from map of
registered processes in BpelServerImpl.java (and some logging consistency)
Posted by "Matthieu Riou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthieu Riou updated ODE-204:
------------------------------
Fix Version/s: (was: 1.3)
> Properly remove process from map of registered processes in BpelServerImpl.java (and some logging consistency)
> --------------------------------------------------------------------------------------------------------------
>
> Key: ODE-204
> URL: https://issues.apache.org/jira/browse/ODE-204
> Project: ODE
> Issue Type: Bug
> Components: Axis2 Integration
> Affects Versions: 1.1
> Environment: ODE 1.1
> Axis2 Distro
> JDK 1.5.0_10
> Jetty 6.1.1
> Reporter: Richard Taylor
> Assignee: Matthieu Riou
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: file.patch
>
>
> First item:
> Wanted to add consistency to the logging messages when deploying a new process
> 1. When deploying, the term "Activated" is used. However when undeploying, the term "Unregistered" is used.
> 2. When deploying a new process, the log says "Process foo-1 has been unregistered", even if a no previous versions of foo were deployed. This was due to accidentally putting the log call outside of a conditional
> Second item:
> I haven't seen any direct affects from this code, but it is a bit off. "p" is never assigned a value before being referenced. From
> BpelServerImpl.java:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
> _engine.unregisterProcess(pid);
> _registeredProcesses.remove(p);
> }
> Seems it should be something like this:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
> p = _engine.unregisterProcess(pid);
> if (p != null)
> {
> _registeredProcesses.remove(p);
> }
> }
> A patch will be attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-204) Properly remove process from map of
registered processes in BpelServerImpl.java (and some logging consistency)
Posted by "Richard Taylor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Taylor updated ODE-204:
-------------------------------
Attachment: file.patch
A patch for the proposed changes
> Properly remove process from map of registered processes in BpelServerImpl.java (and some logging consistency)
> --------------------------------------------------------------------------------------------------------------
>
> Key: ODE-204
> URL: https://issues.apache.org/jira/browse/ODE-204
> Project: ODE
> Issue Type: Bug
> Components: Axis2 Integration
> Affects Versions: 1.1
> Environment: ODE 1.1
> Axis2 Distro
> JDK 1.5.0_10
> Jetty 6.1.1
> Reporter: Richard Taylor
> Priority: Trivial
> Fix For: 1.1.1, 1.2
>
> Attachments: file.patch
>
>
> First item:
> Wanted to add consistency to the logging messages when deploying a new process
> 1. When deploying, the term "Activated" is used. However when undeploying, the term "Unregistered" is used.
> 2. When deploying a new process, the log says "Process foo-1 has been unregistered", even if a no previous versions of foo were deployed. This was due to accidentally putting the log call outside of a conditional
> Second item:
> I haven't seen any direct affects from this code, but it is a bit off. "p" is never assigned a value before being referenced. From
> BpelServerImpl.java:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
> _engine.unregisterProcess(pid);
> _registeredProcesses.remove(p);
> }
> Seems it should be something like this:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
> p = _engine.unregisterProcess(pid);
> if (p != null)
> {
> _registeredProcesses.remove(p);
> }
> }
> A patch will be attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-204) Properly remove process from map of
registered processes in BpelServerImpl.java (and some logging consistency)
Posted by "Matthieu Riou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthieu Riou resolved ODE-204.
-------------------------------
Resolution: Fixed
Assignee: Matthieu Riou
Patch applied. Thanks!
> Properly remove process from map of registered processes in BpelServerImpl.java (and some logging consistency)
> --------------------------------------------------------------------------------------------------------------
>
> Key: ODE-204
> URL: https://issues.apache.org/jira/browse/ODE-204
> Project: ODE
> Issue Type: Bug
> Components: Axis2 Integration
> Affects Versions: 1.1
> Environment: ODE 1.1
> Axis2 Distro
> JDK 1.5.0_10
> Jetty 6.1.1
> Reporter: Richard Taylor
> Assignee: Matthieu Riou
> Priority: Trivial
> Fix For: 1.1.1, 1.2
>
> Attachments: file.patch
>
>
> First item:
> Wanted to add consistency to the logging messages when deploying a new process
> 1. When deploying, the term "Activated" is used. However when undeploying, the term "Unregistered" is used.
> 2. When deploying a new process, the log says "Process foo-1 has been unregistered", even if a no previous versions of foo were deployed. This was due to accidentally putting the log call outside of a conditional
> Second item:
> I haven't seen any direct affects from this code, but it is a bit off. "p" is never assigned a value before being referenced. From
> BpelServerImpl.java:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
> _engine.unregisterProcess(pid);
> _registeredProcesses.remove(p);
> }
> Seems it should be something like this:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
> p = _engine.unregisterProcess(pid);
> if (p != null)
> {
> _registeredProcesses.remove(p);
> }
> }
> A patch will be attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.