[GitHub] [incubator-superset] betodealmeida opened a new pull request #7975: Fix for new Pandas API

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #7975: Fix for new Pandas API
URL: https://github.com/apache/incubator-superset/pull/7975
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR fixes https://github.com/apache/incubator-superset/issues/7966, where the Time-series Period Pivot visualization is broken because of changes to the Pandas API:
   
   1. `DateOffset` is now immutable, so we can't set it to normalized after it's been created. I fixed this my making a copy and normalizing it during the process.
   2. Having an index with the same name as a column now raises an exception. I fixed this by removing the name of the index (since we don't use it).
   
   I'm not very familiar with Pandas, so I'm not sure if this is the right approach.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   I compared visualizations that we have in production at Lyft (running the old code that still works), and the ones created with this PR are identical.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @villebro 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org