You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/10 23:31:15 UTC
[GitHub] [lucene-solr] mrsoong opened a new pull request #1502: Added 400 status code to exception in DynamicField
mrsoong opened a new pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The RuntimeException that the DynamicField parser throws is never caught. In at least one case this results in a 500 error being thrown.
# Solution
Replaced the RuntimeException with a SOLRException with an error code set to 400
# Tests
Added TestExtendedDismaxParser.testInvalidDynamicField which covers DynamicField for an invalid input that can cause this bug
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title. (Existing issue)
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `ant precommit` and the appropriate test suite.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #1502: Added 400 status code to exception in DynamicField
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502#issuecomment-626412303
LGTM needs a changed entry, will try to commit this week if nobody else has eyes on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn commented on pull request #1502: SOLR-13203: Added 400 status code to exception in DynamicField
Posted by GitBox <gi...@apache.org>.
munendrasn commented on pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502#issuecomment-640209147
@mrsoong Thanks for the contribution. I have included your GitHub username in the changes.txt. Let me know if that needs to be modified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mrsoong commented on pull request #1502: SOLR-13203: Added 400 status code to exception in DynamicField
Posted by GitBox <gi...@apache.org>.
mrsoong commented on pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502#issuecomment-631138690
Hi @madrob. Just wanted to drop a friendly reminder that this PR is still waiting for the changed entry that you mentioned more than a week ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mrsoong commented on pull request #1502: SOLR-13203: Added 400 status code to exception in DynamicField
Posted by GitBox <gi...@apache.org>.
mrsoong commented on pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502#issuecomment-626413312
I forgot to link the appropriate JIRA issue, sorry about that. The title should be correct now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mrsoong commented on pull request #1502: SOLR-13203: Added 400 status code to exception in DynamicField
Posted by GitBox <gi...@apache.org>.
mrsoong commented on pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502#issuecomment-640745342
Thank you for helping to get this merged @munendrasn. The new entry in changes.txt looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] munendrasn merged pull request #1502: SOLR-13203: Added 400 status code to exception in DynamicField
Posted by GitBox <gi...@apache.org>.
munendrasn merged pull request #1502:
URL: https://github.com/apache/lucene-solr/pull/1502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org