You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/08/02 18:48:20 UTC

[GitHub] [pinot] shenyu0127 opened a new pull request, #11250: Refine testExpressionFilterOperatorApplyAndForGetFalses.

shenyu0127 opened a new pull request, #11250:
URL: https://github.com/apache/pinot/pull/11250

   In `ExpressionScanDocIdIterator::processProjectionBlock`, if we mistakenly add local document IDs [0, `projectionBlock.getNumDocs()`) to `matchingDocIds`, the refined test will fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11250: Add and refine tests for ExpressionScanDocIdIterator.

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11250:
URL: https://github.com/apache/pinot/pull/11250#discussion_r1282483153


##########
pinot-core/src/test/java/org/apache/pinot/queries/NullHandlingEnabledQueriesTest.java:
##########
@@ -834,14 +835,38 @@ public void testGreatestExpressionFilterOperator()
     assertEquals(rows.size(), NUM_OF_SEGMENT_COPIES * 4);
   }
 
+  @Test
+  public void testExpressionFilterOperatorResultIsInSecondProjectionBlock()
+      throws Exception {
+    initializeRows();
+    int i = 0;
+    for (; i < DocIdSetPlanNode.MAX_DOC_PER_CALL; i++) {
+      insertRowWithTwoColumns(null, i);
+    }
+    insertRowWithTwoColumns(1, i);

Review Comment:
   ```suggestion
       for (int i = 0; i < DocIdSetPlanNode.MAX_DOC_PER_CALL; i++) {
         insertRowWithTwoColumns(null, i);
       }
       insertRowWithTwoColumns(1, DocIdSetPlanNode.MAX_DOC_PER_CALL);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] shenyu0127 commented on pull request #11250: Add and refine tests for ExpressionScanDocIdIterator.

Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #11250:
URL: https://github.com/apache/pinot/pull/11250#issuecomment-1662987216

   > Suggest adding more rows so that we can test more scenarios
   Added a new test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang merged pull request #11250: Add and refine tests for ExpressionScanDocIdIterator.

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11250:
URL: https://github.com/apache/pinot/pull/11250


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] codecov-commenter commented on pull request #11250: Refine testExpressionFilterOperatorApplyAndForGetFalses.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11250:
URL: https://github.com/apache/pinot/pull/11250#issuecomment-1662856898

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#11250](https://app.codecov.io/gh/apache/pinot/pull/11250?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (478827a) into [master](https://app.codecov.io/gh/apache/pinot/commit/5d312e5a3f9e7c6edf152e60506c3c7a222c75d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5d312e5) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #11250     +/-   ##
   =========================================
     Coverage    0.11%    0.11%             
   =========================================
     Files        2229     2155     -74     
     Lines      119957   116802   -3155     
     Branches    18173    17727    -446     
   =========================================
     Hits          137      137             
   + Misses     119800   116645   -3155     
     Partials       20       20             
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1temurin11 | `?` | |
   | integration1temurin20 | `?` | |
   | integration2temurin11 | `?` | |
   | integration2temurin20 | `?` | |
   | unittests1temurin11 | `?` | |
   | unittests1temurin17 | `?` | |
   | unittests1temurin20 | `?` | |
   | unittests2temurin11 | `0.11% <ø> (ø)` | |
   | unittests2temurin17 | `0.11% <ø> (ø)` | |
   | unittests2temurin20 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 74 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11250/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org