[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4493: Add Datum Arithmetic tests (#4480)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4493:
URL: https://github.com/apache/arrow-rs/pull/4493#discussion_r1257345327


##########
arrow-arith/src/arithmetic.rs:
##########
@@ -1315,7 +1315,7 @@ mod tests {
         let c = c.as_any().downcast_ref::<Date32Array>().unwrap();
         assert_eq!(
             c.value(0),
-            Date32Type::from_naive_date(NaiveDate::from_ymd_opt(2023, 3, 27).unwrap())
+            Date32Type::from_naive_date(NaiveDate::from_ymd_opt(2023, 3, 28).unwrap())

Review Comment:
   The previous logic was incorrect but happened to give a potentially plausible result. I'm not sure what the correct rounding behaviour is here though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org