You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/12/01 17:02:47 UTC
Re: Review Request 27810: Alerts: SNMP Target for Notifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27810/#review63368
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105585>
It's cleaner and less error prone to put the required properties in a static list.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105603>
Why not just use SnmpVersion.values() directly?
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105604>
Target security needs to be addressed for v2 and v3.
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105605>
I'm guessing this is a synchronous send event (which is fine). But if it's synchrounous, then a PDU response is returned which should be evaluated before calling ```successCallback(...)```
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105607>
Why not also handle v3 since you're using the PDU factory anyway?
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
<https://reviews.apache.org/r/27810/#comment105602>
This method is not needed.
- Jonathan Hurley
On Nov. 26, 2014, 12:19 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27810/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 12:19 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Srimanth Gunturi, and Yusaku Sako.
>
>
> Bugs: AMBARI-8251
> https://issues.apache.org/jira/browse/AMBARI-8251
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Ambari Server will be responsible for scheduling the dispatching of alerts that have been received and not yet processed for outbound notification. On a schedule, Ambari will determine the alert targets that should be receiving some sort of notification and then it will gather all alert data for all alerts that are destined for that alert target.
> SNMP is a required notification mechanism. Each alert defined in the system will act as an SNMP trap.
> Templates should be used where applicable (ie email/velocity) in order to provide robust, customizable notifications.
>
>
> Diffs
> -----
>
> ambari-server/pom.xml e03b626
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchCredentials.java 9514474
> ambari-server/src/main/java/org/apache/ambari/server/notifications/DispatchFactory.java e690e76
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Notification.java 12dffd7
> ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java 10946be
> ambari-server/src/main/java/org/apache/ambari/server/notifications/Recipient.java 933038b
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java f979c03
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 69f3393
> ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java 1e7689f
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcherTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java 2e984bf
>
> Diff: https://reviews.apache.org/r/27810/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.589s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.429s]
> [INFO] Ambari Web ........................................ SUCCESS [52.018s]
> [INFO] Ambari Views ...................................... SUCCESS [15.517s]
> [INFO] Ambari Admin View ................................. SUCCESS [1:07.079s]
> [INFO] Ambari Server ..................................... SUCCESS [1:04:44.218s]
> [INFO] Ambari Agent ...................................... SUCCESS [28.370s]
> [INFO] Ambari Client ..................................... SUCCESS [0.733s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.351s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [17.228s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.639s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.162s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.510s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:04.344s
> [INFO] Finished at: Wed Nov 26 15:11:12 CET 2014
> [INFO] Final Memory: 58M/676M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yurii Shylov
>
>