You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/08 04:04:07 UTC

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15694: Improve openblas CMake logic, add generic blas option.

larroy commented on a change in pull request #15694: Improve openblas CMake logic, add generic blas option.
URL: https://github.com/apache/incubator-mxnet/pull/15694#discussion_r321990922
 
 

 ##########
 File path: 3rdparty/mshadow/cmake/mshadow.cmake
 ##########
 @@ -1,34 +1,40 @@
 set(mshadow_LINKER_LIBS "")
 
-set(BLAS "Open" CACHE STRING "Selected BLAS library")
-set_property(CACHE BLAS PROPERTY STRINGS "Atlas;Open;MKL")
+set(BLAS "openblas" CACHE STRING "Selected BLAS library")
 
 Review comment:
   It makes it consistent with Makefile, that's the whole point of the PR. Please reconsider your veto.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services