You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/27 05:42:31 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #17997: Use null databaseName when creating ShardingSphereDataSource in scaling for now

sandynz opened a new pull request, #17997:
URL: https://github.com/apache/shardingsphere/pull/17997

   Try workaround for #17993.
   
   Changes proposed in this pull request:
   - Use null databaseName when creating ShardingSphereDataSource in scaling for now
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17997: Use null databaseName when creating ShardingSphereDataSource in scaling for now

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17997:
URL: https://github.com/apache/shardingsphere/pull/17997#issuecomment-1139319132

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17997](https://codecov.io/gh/apache/shardingsphere/pull/17997?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84a36b6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e3ed3b216ae70f14a2dce96c68f4e672a835700a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3ed3b2) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17997      +/-   ##
   ============================================
   - Coverage     58.91%   58.91%   -0.01%     
     Complexity     2145     2145              
   ============================================
     Files          3648     3648              
     Lines         54040    54041       +1     
     Branches       9181     9181              
   ============================================
     Hits          31838    31838              
   - Misses        19500    19501       +1     
     Partials       2702     2702              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17997?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...eator/ShardingSpherePipelineDataSourceCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/17997/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9kYXRhL3BpcGVsaW5lL2RhdGFzb3VyY2UvY3JlYXRvci9TaGFyZGluZ1NwaGVyZVBpcGVsaW5lRGF0YVNvdXJjZUNyZWF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17997?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17997?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3ed3b2...84a36b6](https://codecov.io/gh/apache/shardingsphere/pull/17997?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #17997: Use null databaseName when creating ShardingSphereDataSource in scaling for now

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #17997:
URL: https://github.com/apache/shardingsphere/pull/17997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org