You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/03/20 21:18:43 UTC
[PR] GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI [arrow]
alinaliBQ opened a new pull request, #49575:
URL: https://github.com/apache/arrow/pull/49575
### Rationale for this change
GH-49563
### What changes are included in this PR?
This issue occurred without any code changes, so I think it is due to an macOS update.
After a GitHub macOS update, the `CLANG_TOOLS_PATH` path is resolved as `/usr/local/bin/clang-format` in Intel CI. Before the GitHub macOS update, `CLANG_TOOLS_PATH` was resolved as `/usr/local/opt/llvm@18/bin` and we did not have the issue of `libunwind` linking dynamically to ODBC dylib.
The solution is to explicitly set `CLANG_TOOLS_PATH` to `llvm@18/bin` on Intel machines.
### Are these changes tested?
- Tested in CI
### Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #49575:
URL: https://github.com/apache/arrow/pull/49575#issuecomment-4114663588
Hmm. I don't know why this fixes the problem... The build doesn't use LLVM because Gandiva is off. Why do clang based tools relate to linked libraries...?
Anyway, we don't need them. Can we solve the problem by removing clang-tools and infer-tools related codes something like the following?
```diff
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index ea15bb7066..a77ed39eac 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -211,17 +211,6 @@ else()
set(MSVC_TOOLCHAIN FALSE)
endif()
-find_package(ClangTools)
-find_package(InferTools)
-if("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1"
- OR CLANG_TIDY_FOUND
- OR INFER_FOUND)
- # Generate a Clang compile_commands.json "compilation database" file for use
- # with various development tools, such as Vim's YouCompleteMe plugin.
- # See http://clang.llvm.org/docs/JSONCompilationDatabase.html
- set(CMAKE_EXPORT_COMPILE_COMMANDS 1)
-endif()
-
# Needed for Gandiva.
# Use the first Python installation on PATH, not the newest one
set(Python3_FIND_STRATEGY "LOCATION")
@@ -649,22 +638,6 @@ if(UNIX)
VERBATIM)
endif(UNIX)
-#
-# "make infer" target
-#
-
-if(${INFER_FOUND})
- # runs infer capture
- add_custom_target(infer ${BUILD_SUPPORT_DIR}/run-infer.sh ${INFER_BIN}
- ${CMAKE_BINARY_DIR}/compile_commands.json 1)
- # runs infer analyze
- add_custom_target(infer-analyze ${BUILD_SUPPORT_DIR}/run-infer.sh ${INFER_BIN}
- ${CMAKE_BINARY_DIR}/compile_commands.json 2)
- # runs infer report
- add_custom_target(infer-report ${BUILD_SUPPORT_DIR}/run-infer.sh ${INFER_BIN}
- ${CMAKE_BINARY_DIR}/compile_commands.json 3)
-endif()
-
#
# Link targets
#
```
```bash
git rm cpp/cmake_modules/FindClangTools.cmake
git rm cpp/cmake_modules/FindInferTools.cmake
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49575:
URL: https://github.com/apache/arrow/pull/49575#issuecomment-4112272374
@kou @lidavidm This PR is ready for review, please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49575:
URL: https://github.com/apache/arrow/pull/49575#issuecomment-4101012457
:warning: GitHub issue #49563 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][CMake] Remove clang/infer tools detection [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49575:
URL: https://github.com/apache/arrow/pull/49575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][CMake] Remove clang/infer tools detection [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49575:
URL: https://github.com/apache/arrow/pull/49575#issuecomment-4131600131
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbfb2420377fc9955dc0e4b5f2d3d1e9d6146211.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/68653663343) has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49575:
URL: https://github.com/apache/arrow/pull/49575#issuecomment-4128214148
@kou The new approach worked, I have updated the PR description, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49575:
URL: https://github.com/apache/arrow/pull/49575#issuecomment-4121953950
Sure, let's try that. I have pushed the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org