You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2006/10/03 17:06:23 UTC
[jira] Created: (JCR-583) TCK: NodeReadMethodsTest.testGetName
fails with NPE if 'testroot' has no child node
TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
------------------------------------------------------------------------------------
Key: JCR-583
URL: http://issues.apache.org/jira/browse/JCR-583
Project: Jackrabbit
Issue Type: Bug
Reporter: angela
Priority: Trivial
The 'testGetName' does not assert, that the childnode field has been populated during setup.
if for whatever reason the test data don't provide a single childnode below the test root, this test will fail with nullpointer
exception.
i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException in case of
missing child node.
patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-583) TCK: NodeReadMethodsTest.testGetName
fails with NPE if 'testroot' has no child node
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-583?page=all ]
angela updated JCR-583:
-----------------------
Attachment: NodeReadMethodsTest.patch
patch for this issue.
btw: 'testGetName' initially tests if the root node's name is "". This is already covered by RootNodeTest.testGetName and i would rather not mix this into the 'testGetName' case, which states in the JavaDoc, that the last segment of the path and the name are being compared. For this reason i removed the additional test for the root node in the patch.
> TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
> ------------------------------------------------------------------------------------
>
> Key: JCR-583
> URL: http://issues.apache.org/jira/browse/JCR-583
> Project: Jackrabbit
> Issue Type: Bug
> Reporter: angela
> Priority: Trivial
> Attachments: NodeReadMethodsTest.patch
>
>
> The 'testGetName' does not assert, that the childnode field has been populated during setup.
> if for whatever reason the test data don't provide a single childnode below the test root, this test will fail with nullpointer
> exception.
> i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException in case of
> missing child node.
> patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-583) TCK: NodeReadMethodsTest.testGetName
fails with NPE if 'testroot' has no child node
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-583?page=all ]
Marcel Reutegger updated JCR-583:
---------------------------------
Affects Version/s: 1.0
> TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
> ------------------------------------------------------------------------------------
>
> Key: JCR-583
> URL: http://issues.apache.org/jira/browse/JCR-583
> Project: Jackrabbit
> Issue Type: Bug
> Components: JCR TCK
> Affects Versions: 1.0
> Reporter: angela
> Priority: Trivial
> Attachments: NodeReadMethodsTest.patch
>
>
> The 'testGetName' does not assert, that the childnode field has been populated during setup.
> if for whatever reason the test data don't provide a single childnode below the test root, this test will fail with nullpointer
> exception.
> i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException in case of
> missing child node.
> patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-583) TCK: NodeReadMethodsTest.testGetName
fails with NPE if 'testroot' has no child node
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-583?page=all ]
Marcel Reutegger resolved JCR-583.
----------------------------------
Resolution: Fixed
Fixed in revision: 480975
Thanks a lot for the patch.
> TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
> ------------------------------------------------------------------------------------
>
> Key: JCR-583
> URL: http://issues.apache.org/jira/browse/JCR-583
> Project: Jackrabbit
> Issue Type: Bug
> Components: JCR TCK
> Affects Versions: 1.0
> Reporter: angela
> Priority: Trivial
> Attachments: NodeReadMethodsTest.patch
>
>
> The 'testGetName' does not assert, that the childnode field has been populated during setup.
> if for whatever reason the test data don't provide a single childnode below the test root, this test will fail with nullpointer
> exception.
> i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException in case of
> missing child node.
> patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-583) TCK: NodeReadMethodsTest.testGetName
fails with NPE if 'testroot' has no child node
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-583?page=all ]
Jukka Zitting updated JCR-583:
------------------------------
Component/s: JCR TCK
> TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
> ------------------------------------------------------------------------------------
>
> Key: JCR-583
> URL: http://issues.apache.org/jira/browse/JCR-583
> Project: Jackrabbit
> Issue Type: Bug
> Components: JCR TCK
> Reporter: angela
> Priority: Trivial
> Attachments: NodeReadMethodsTest.patch
>
>
> The 'testGetName' does not assert, that the childnode field has been populated during setup.
> if for whatever reason the test data don't provide a single childnode below the test root, this test will fail with nullpointer
> exception.
> i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException in case of
> missing child node.
> patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (JCR-583) TCK: NodeReadMethodsTest.testGetName fails
with NPE if 'testroot' has no child node
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting closed JCR-583.
-----------------------------
> TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
> ------------------------------------------------------------------------------------
>
> Key: JCR-583
> URL: https://issues.apache.org/jira/browse/JCR-583
> Project: Jackrabbit
> Issue Type: Bug
> Components: JCR TCK
> Affects Versions: 1.0
> Reporter: angela
> Priority: Trivial
> Attachments: NodeReadMethodsTest.patch
>
>
> The 'testGetName' does not assert, that the childnode field has been populated during setup.
> if for whatever reason the test data don't provide a single childnode below the test root, this test will fail with nullpointer
> exception.
> i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException in case of
> missing child node.
> patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.