You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/13 03:24:38 UTC
Re: Review Request 20297: Added API for managing IP packet filters.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review42800
-----------------------------------------------------------
Ship it!
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76716>
s/has/have/
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76717>
s/offset/offset of/ ?
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76718>
s/destinationIP/destinationPorts/
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76719>
why not offset and mask on the same line...?
if (offset = 8 && mask = 0x00ff0000) {
}
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76720>
can you mention which part?
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76721>
ditto.
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76722>
ditto.
src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76724>
include the value of size in the message.
- Vinod Kone
On April 28, 2014, 5:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20297/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 5:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The is Part 5 of the linux routing library.
>
>
> Diffs
> -----
>
> src/Makefile.am d2e006d
> src/linux/routing/filter/ip.hpp PRE-CREATION
> src/linux/routing/filter/ip.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20297/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 20297: Added API for managing IP packet filters.
Posted by Jie Yu <yu...@gmail.com>.
> On May 13, 2014, 1:24 a.m., Vinod Kone wrote:
> > src/linux/routing/filter/ip.cpp, line 184
> > <https://reviews.apache.org/r/20297/diff/4/?file=569537#file569537line184>
> >
> > s/destinationIP/destinationPorts/
Oops! Good catch! This is not captured by the unit test. I added another unit test for capturing the regression.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review42800
-----------------------------------------------------------
On April 28, 2014, 5:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20297/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 5:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Bugs: MESOS-1228
> https://issues.apache.org/jira/browse/MESOS-1228
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The is Part 5 of the linux routing library.
>
>
> Diffs
> -----
>
> src/Makefile.am d2e006d
> src/linux/routing/filter/ip.hpp PRE-CREATION
> src/linux/routing/filter/ip.cpp PRE-CREATION
> src/tests/routing_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20297/diff/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>