You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by gn...@apache.org on 2017/09/05 07:23:33 UTC
[3/3] karaf git commit: Remove some IDE warnings
Remove some IDE warnings
Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/4bd4445b
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/4bd4445b
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/4bd4445b
Branch: refs/heads/master
Commit: 4bd4445bfb1c71115f005f2488d38b264d26fd7a
Parents: 178dfef
Author: Guillaume Nodet <gn...@apache.org>
Authored: Mon Sep 4 10:00:45 2017 +0200
Committer: Guillaume Nodet <gn...@apache.org>
Committed: Tue Sep 5 09:23:26 2017 +0200
----------------------------------------------------------------------
.../java/org/apache/karaf/maven/command/PasswordCommand.java | 1 -
.../org/apache/karaf/maven/command/RepositoryAddCommand.java | 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/karaf/blob/4bd4445b/maven/core/src/main/java/org/apache/karaf/maven/command/PasswordCommand.java
----------------------------------------------------------------------
diff --git a/maven/core/src/main/java/org/apache/karaf/maven/command/PasswordCommand.java b/maven/core/src/main/java/org/apache/karaf/maven/command/PasswordCommand.java
index 4243212..ceaf90e 100644
--- a/maven/core/src/main/java/org/apache/karaf/maven/command/PasswordCommand.java
+++ b/maven/core/src/main/java/org/apache/karaf/maven/command/PasswordCommand.java
@@ -93,7 +93,6 @@ public class PasswordCommand extends MavenConfigurationSupport {
config.put(prefix + PROPERTY_SECURITY_FILE, newSecuritySettingsFile.getCanonicalPath());
cmConfig.update(config);
}
- return;
}
}
http://git-wip-us.apache.org/repos/asf/karaf/blob/4bd4445b/maven/core/src/main/java/org/apache/karaf/maven/command/RepositoryAddCommand.java
----------------------------------------------------------------------
diff --git a/maven/core/src/main/java/org/apache/karaf/maven/command/RepositoryAddCommand.java b/maven/core/src/main/java/org/apache/karaf/maven/command/RepositoryAddCommand.java
index 1001ade..5ab8092 100644
--- a/maven/core/src/main/java/org/apache/karaf/maven/command/RepositoryAddCommand.java
+++ b/maven/core/src/main/java/org/apache/karaf/maven/command/RepositoryAddCommand.java
@@ -117,15 +117,15 @@ public class RepositoryAddCommand extends RepositoryEditCommandSupport {
StringBuilder sb = new StringBuilder();
sb.append(urlResolved.val());
- sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_ID + "=" + id);
+ sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_ID + "=").append(id);
if (snapshots) {
sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_ALLOW_SNAPSHOTS);
}
if (noReleases) {
sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_DISALLOW_RELEASES);
}
- sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_UPDATE + "=" + updatePolicy);
- sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_CHECKSUM + "=" + checksumPolicy);
+ sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_UPDATE + "=").append(updatePolicy);
+ sb.append(ServiceConstants.SEPARATOR_OPTIONS + ServiceConstants.OPTION_CHECKSUM + "=").append(checksumPolicy);
MavenRepositoryURL newRepository = new MavenRepositoryURL(sb.toString());
List<MavenRepositoryURL> newRepos = new LinkedList<>(Arrays.asList(pidRepos));