[GitHub] jaydoane commented on issue #1629: handle db deletion in load validation funs

[GitBox <gi...@apache.org>]

jaydoane commented on issue #1629: handle db deletion in load validation funs
URL: https://github.com/apache/couchdb/pull/1629#issuecomment-440395007
 
 
   New changes look good:
   ```
   $ make eunit apps=couch tests=clustered_db_test
     DB deletion
       couchdb_db_tests:53: should_close_deleted_db...[0.028 s] ok
       couchdb_db_tests:75: should_kill_caller_from_load_validation_funs_for_deleted_db...[0.032 s] ok
   =======================================================
     2 tests passed.
   ```
   ```
   $ make eunit apps=ddoc_cache
   ...
   =======================================================
     All 51 tests passed.
   ```
   
   Just a couple minor quibbles:
   - The second line of the commit says "Previously there were few problems with load_validation_funs". I think you mean "*a* few problems", since omitting the article "a" makes it sound like there were not that many problems. In short, it inverts the meaning.
   - Some functions in the new test modules don't have 2 lines between them in places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services