You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/27 05:53:41 UTC
[GitHub] [incubator-druid] justinborromeo commented on issue #7133: Time
Ordering On Scans
justinborromeo commented on issue #7133: Time Ordering On Scans
URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-476988260
For the unordered case, there is no performance regression as demonstrated by the results of the ScanBenchmark before and after the PR below. The benchmark was run on an EC2 instance.
```
java -Xmx8g -server -jar target/benchmarks.jar ScanBenchmark -f 1 -i 50 -wi 25 -p schemaAndQuery=basic.A -p ordering=NONE -p limit=0,1000,99999
After PR:
# Run complete. Total time: 00:33:03
Benchmark (limit) (numProcessingThreads) (numSegments) (rowsPerSegment) (schemaAndQuery) Mode Cnt Score Error Units
ScanBenchmark.queryMultiQueryableIndex 0 2 2 200000 basic.A avgt 50 1047299.585 ± 100832.876 us/op
ScanBenchmark.queryMultiQueryableIndex 0 2 4 200000 basic.A avgt 50 3327877.446 ± 340896.932 us/op
ScanBenchmark.queryMultiQueryableIndex 1000 2 2 200000 basic.A avgt 50 2871.893 ± 1.312 us/op
ScanBenchmark.queryMultiQueryableIndex 1000 2 4 200000 basic.A avgt 50 2932.073 ± 3.538 us/op
ScanBenchmark.queryMultiQueryableIndex 99999 2 2 200000 basic.A avgt 50 230683.292 ± 1364.525 us/op
ScanBenchmark.queryMultiQueryableIndex 99999 2 4 200000 basic.A avgt 50 231715.616 ± 1572.446 us/op
ScanBenchmark.querySingleIncrementalIndex 0 2 2 200000 basic.A avgt 50 349069.471 ± 4376.445 us/op
ScanBenchmark.querySingleIncrementalIndex 0 2 4 200000 basic.A avgt 50 340061.203 ± 3059.043 us/op
ScanBenchmark.querySingleIncrementalIndex 1000 2 2 200000 basic.A avgt 50 1258.837 ± 0.716 us/op
ScanBenchmark.querySingleIncrementalIndex 1000 2 4 200000 basic.A avgt 50 1320.102 ± 1.458 us/op
ScanBenchmark.querySingleIncrementalIndex 99999 2 2 200000 basic.A avgt 50 155196.629 ± 1357.245 us/op
ScanBenchmark.querySingleIncrementalIndex 99999 2 4 200000 basic.A avgt 50 162660.413 ± 1560.482 us/op
ScanBenchmark.querySingleQueryableIndex 0 2 2 200000 basic.A avgt 50 492261.267 ± 5470.700 us/op
ScanBenchmark.querySingleQueryableIndex 0 2 4 200000 basic.A avgt 50 480649.890 ± 5540.968 us/op
ScanBenchmark.querySingleQueryableIndex 1000 2 2 200000 basic.A avgt 50 2795.713 ± 1.473 us/op
ScanBenchmark.querySingleQueryableIndex 1000 2 4 200000 basic.A avgt 50 2864.783 ± 2.959 us/op
ScanBenchmark.querySingleQueryableIndex 99999 2 2 200000 basic.A avgt 50 240433.943 ± 1845.204 us/op
ScanBenchmark.querySingleQueryableIndex 99999 2 4 200000 basic.A avgt 50 234122.746 ± 1507.052 us/op
Before PR:
# Run complete. Total time: 00:33:02
Benchmark (limit) (numProcessingThreads) (numSegments) (rowsPerSegment) (schemaAndQuery) Mode Cnt Score Error Units
ScanBenchmark.queryMultiQueryableIndex 0 2 2 200000 basic.A avgt 50 1172830.904 ± 201573.754 us/op
ScanBenchmark.queryMultiQueryableIndex 0 2 4 200000 basic.A avgt 50 3267726.979 ± 319137.068 us/op
ScanBenchmark.queryMultiQueryableIndex 1000 2 2 200000 basic.A avgt 50 2824.916 ± 3.079 us/op
ScanBenchmark.queryMultiQueryableIndex 1000 2 4 200000 basic.A avgt 50 2777.685 ± 3.450 us/op
ScanBenchmark.queryMultiQueryableIndex 99999 2 2 200000 basic.A avgt 50 231104.252 ± 1376.867 us/op
ScanBenchmark.queryMultiQueryableIndex 99999 2 4 200000 basic.A avgt 50 231335.680 ± 1355.400 us/op
ScanBenchmark.querySingleIncrementalIndex 0 2 2 200000 basic.A avgt 50 342828.419 ± 4551.446 us/op
ScanBenchmark.querySingleIncrementalIndex 0 2 4 200000 basic.A avgt 50 333952.670 ± 3096.050 us/op
ScanBenchmark.querySingleIncrementalIndex 1000 2 2 200000 basic.A avgt 50 1307.223 ± 0.686 us/op
ScanBenchmark.querySingleIncrementalIndex 1000 2 4 200000 basic.A avgt 50 1288.650 ± 1.255 us/op
ScanBenchmark.querySingleIncrementalIndex 99999 2 2 200000 basic.A avgt 50 158636.920 ± 781.898 us/op
ScanBenchmark.querySingleIncrementalIndex 99999 2 4 200000 basic.A avgt 50 162173.353 ± 961.087 us/op
ScanBenchmark.querySingleQueryableIndex 0 2 2 200000 basic.A avgt 50 488685.621 ± 5538.093 us/op
ScanBenchmark.querySingleQueryableIndex 0 2 4 200000 basic.A avgt 50 486952.922 ± 5868.651 us/op
ScanBenchmark.querySingleQueryableIndex 1000 2 2 200000 basic.A avgt 50 2879.226 ± 1.755 us/op
ScanBenchmark.querySingleQueryableIndex 1000 2 4 200000 basic.A avgt 50 2823.509 ± 21.211 us/op
ScanBenchmark.querySingleQueryableIndex 99999 2 2 200000 basic.A avgt 50 238340.781 ± 1514.616 us/op
ScanBenchmark.querySingleQueryableIndex 99999 2 4 200000 basic.A avgt 50 235502.141 ± 1402.612 us/op
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org