[jira] Resolved: (JSPF-29) Simplify DNSService service interface

["Stefano Bagnara (JIRA)" <se...@james.apache.org>]

     [ http://issues.apache.org/jira/browse/JSPF-29?page=all ]

Stefano Bagnara resolved JSPF-29.
---------------------------------

    Resolution: Fixed

Now much code has been moved from the DNSService to the spf library. This mean we have less code in the specific implementation and no business-related code in the services. clover coverage is now 77% (88% for the library classes)

> Simplify DNSService service interface
> -------------------------------------
>
>                 Key: JSPF-29
>                 URL: http://issues.apache.org/jira/browse/JSPF-29
>             Project: jSPF
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 0.9b3
>            Reporter: Stefano Bagnara
>         Assigned To: Stefano Bagnara
>             Fix For: 0.9b4
>
>
> DNSService contains too much logic and we are not able to unit-test this part because of the networking needed.
> So we should try to simplify it as much as possible.
> 1) Remove NoneException and simply return null when no result is found.
> 2) Refactor it to include a generci getRecords(host, recordType)
> 3) Decide wether to introduce a TimeoutException or simply reuse the TempErrorException we use now.
> 4) Move code for specific lookups getARecords/getMXRecords/getPTRRecords/getAAAARecords and so on into the caller terms (or other code). We currenlty have very few callers for that services so it should not be a problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org