[GitHub] [lucene-solr] dsmiley commented on pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #2166:
URL: https://github.com/apache/lucene-solr/pull/2166#issuecomment-759490172


   The PR is about introducing a low level utility that we expect will be useful for custom DirectoryFactory implementations _that we don't even have yet_.  It's the kind of thing that many of us wouldn't of even created a separate PR for -- it'd show up in a larger PR that introduces the first user of the utility.  It's not even worth a CHANGES.txt entry IMO; there's always the commit message.  As long as there is no user of this code yet, I'd prefer that we don't merge this yet.  Perhaps we may find that the abstraction here isn't quite right.
   
   RE master (9) vs 8x... If we wait till BlobDirectory, it'd almost certainly be 9. If we don't, ehh... I'd just do 9.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org