You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2025/06/18 17:10:07 UTC

[PR] Complete dags.json and components.json in Arabic [airflow]

shahar1 opened a new pull request, #51898:
URL: https://github.com/apache/airflow/pull/51898

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   CC: @ahmadtfarhan 
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Complete dags.json and components.json in Arabic [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #51898:
URL: https://github.com/apache/airflow/pull/51898#discussion_r2157132958


##########
airflow-core/src/airflow/ui/src/i18n/locales/ar/components.json:
##########
@@ -87,8 +87,7 @@
     "limitedList": "+{{count}} المزيد",
     "logs": {
         "file": "ملف",
-        "in": "في",
-        "line": "سطر"
+        "location": "موقع"

Review Comment:
   Woops, my bad!
   It should be ok now :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Complete dags.json and components.json in Arabic [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #51898:
URL: https://github.com/apache/airflow/pull/51898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Complete dags.json and components.json in Arabic [airflow]

Posted by "ahmadtfarhan (via GitHub)" <gi...@apache.org>.
ahmadtfarhan commented on code in PR #51898:
URL: https://github.com/apache/airflow/pull/51898#discussion_r2155159054


##########
airflow-core/src/airflow/ui/src/i18n/locales/ar/dags.json:
##########
@@ -4,63 +4,28 @@
     "delete": {
       "button": "حذف الDag",
       "warning": "سيؤدي هذا إلى إزالة جميع البيانات الوصفية المرتبطة بالDag، بما في ذلك التشغيلات والمهام."
-    },
-    "trigger": {
-      "button": "تشغيل",
-      "triggerDag": "تشغيل الDag"
     }
   },
   "filters": {
+    "allRunTypes": "جميع أنواع التشغيلات",
+    "allStates": "جميع الحالات",
     "paused": {
       "active": "مفعّل",
       "all": "الكل",
       "paused": "متوقف"
     }
   },
-  "list": {
-    "advancedSearch": "بحث متقدم",
-    "clearSearch": "مسح البحث",
-    "columns": {
-      "dagId": "معرّف الDag",
-      "lastDagRun": "آخر تشغيل لـDag",
-      "nextDagRun": "التشغيل التالي لـDag",
-      "schedule": "الجدولة",
-      "tags": "العلامات"
-    },
-    "ownerLink": "رابط المالك لـ{{owner}}",
-    "searchPlaceholder": "البحث في الDags"
-  },
+  "ownerLink": "رابط المالك لـ{{owner}}",
   "runAndTaskActions": {
+    "affectedTasks": {
+      "noItemsFound": "لم يتم العثور على مهام.",
+      "title": "المهام المتأثرة: {{count}}"
+    },
     "clear": {
       "button": "مسح {{type}}",
       "buttonTooltip": "اضغط shift+c للمسح",
-      "dialog": {
-        "affectedTasks": {
-          "columns": {
-            "mapIndex": "فهرس الخريطة",
-            "runId": "معرف التشغيل",
-            "state": "الحالة",
-            "taskId": "معرف المهمة"
-          },
-          "noItemsFound": "لم يتم العثور على مهام.",
-          "title": "المهام المتأثرة: {{count}}"
-        },
-        "confirm": "تأكيد",
-        "note": {
-          "placeholder": "أضف ملاحظة...",
-          "title": "ملاحظة"
-        },
-        "options": {
-          "downstream": "المهام اللاحقة",
-          "existingTasks": "مسح المهام الحالية",
-          "future": "المستقبل",
-          "onlyFailed": "مسح المهام الفاشلة فقط",
-          "past": "الماضي",
-          "queueNew": "إضافة مهام جديدة للانتظار",
-          "upstream": "المهام السابقة"
-        },
-        "title": "مسح {{type}}"
-      }
+      "error": "حدث خطأ أثناء مسح {{type}}",

Review Comment:
   ...المسح



##########
airflow-core/src/airflow/ui/src/i18n/locales/ar/components.json:
##########
@@ -87,8 +87,7 @@
     "limitedList": "+{{count}} المزيد",
     "logs": {
         "file": "ملف",
-        "in": "في",
-        "line": "سطر"
+        "location": "موقع"

Review Comment:
   This does not match what the en locale is showing. 
   Not sure what is the difference between file and location in the UI to be able to judge but they might need change.



##########
airflow-core/src/airflow/ui/src/i18n/locales/ar/dags.json:
##########
@@ -81,31 +46,24 @@
         "failed": "اضغط shift+f لتمييز كفاشل",
         "success": "اضغط shift+s لتمييز كناجح"
       },
-      "dialog": {
-        "confirm": "تأكيد",
-        "options": {
-          "downstream": "المهام اللاحقة",
-          "future": "المهام المستقبلية",
-          "past": "المهام الماضية",
-          "upstream": "المهام السابقة"
-        },
-        "title": "تمييز {{type}} كـ {{state}}"
-      }
+      "title": "تمييز {{type}} كـ{{state}}"
+    },
+    "options": {
+      "downstream": "المهام اللاحقة",
+      "existingTasks": "مسح المهام الحالية",
+      "future": "المستقبل",
+        "onlyFailed": "مسح المهام الفاشلة فقط",
+        "past": "الماضي",
+        "queueNew": "إضافة مهام جديدة للانتظار",
+            "upstream": "المهام السابقة"
     }
   },
-  "runs": {
-   "allRunTypes": "جميع أنواع التشغيل",
-   "allStates": "جميع الحالات",
-   "columns": {
-     "dagId": "معرف الDag",
-     "dagVersions": "إصدارات الDag",
-     "duration": "المدة",
-     "endDate": "تاريخ الانتهاء",
-     "runAfter": "التشغيل بعد",
-     "runType": "نوع التشغيل",
-     "startDate": "تاريخ البدء",
-     "state": "الحالة"
-   }
+  "search": {
+     "advanced": "بحث متقدم",
+     "clear": "مسح",
+     "dags": "Dags",
+     "hotkey": "+K",
+     "tasks": "مهام"

Review Comment:
   Same as previous comment



##########
airflow-core/src/airflow/ui/src/i18n/locales/ar/dags.json:
##########
@@ -81,31 +46,24 @@
         "failed": "اضغط shift+f لتمييز كفاشل",
         "success": "اضغط shift+s لتمييز كناجح"
       },
-      "dialog": {
-        "confirm": "تأكيد",
-        "options": {
-          "downstream": "المهام اللاحقة",
-          "future": "المهام المستقبلية",
-          "past": "المهام الماضية",
-          "upstream": "المهام السابقة"
-        },
-        "title": "تمييز {{type}} كـ {{state}}"
-      }
+      "title": "تمييز {{type}} كـ{{state}}"
+    },
+    "options": {
+      "downstream": "المهام اللاحقة",
+      "existingTasks": "مسح المهام الحالية",
+      "future": "المستقبل",
+        "onlyFailed": "مسح المهام الفاشلة فقط",
+        "past": "الماضي",
+        "queueNew": "إضافة مهام جديدة للانتظار",
+            "upstream": "المهام السابقة"
     }
   },
-  "runs": {
-   "allRunTypes": "جميع أنواع التشغيل",
-   "allStates": "جميع الحالات",
-   "columns": {
-     "dagId": "معرف الDag",
-     "dagVersions": "إصدارات الDag",
-     "duration": "المدة",
-     "endDate": "تاريخ الانتهاء",
-     "runAfter": "التشغيل بعد",
-     "runType": "نوع التشغيل",
-     "startDate": "تاريخ البدء",
-     "state": "الحالة"
-   }
+  "search": {
+     "advanced": "بحث متقدم",
+     "clear": "مسح",
+     "dags": "Dags",

Review Comment:
   Missing work "search" according to the en locale



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org