You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2015/02/23 01:23:50 UTC
Review Request 31290: SAMAZ-544
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMAZ-544
https://issues.apache.org/jira/browse/SAMAZ-544
Repository: samza
Description
-------
recover test stateful task.
remove trailing csv
remove unit test. user proper constants. enable CMS for container performance test.
delete unit test. add integration test.
Diffs
-----
build.gradle b803276c13280ffed5ca1ce8ea608d81010e9b6b
samza-test/src/main/config/perf/container-performance.properties PRE-CREATION
samza-test/src/main/python/tests/performance_tests.py a97717fc8ecff4d2f8e0ea24ebe0636804f0fbd4
samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala d589d762a18f9425aa8d8dd589011a151bcb59a4
Diff: https://reviews.apache.org/r/31290/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 31290: SAMAZ-544
Posted by Chris Riccomini <cr...@apache.org>.
> On Feb. 25, 2015, 9:43 p.m., Milinda Pathirage wrote:
> > Ship It!
>
> Milinda Pathirage wrote:
> I think I found an issue. But I am not sure whether this is caused by my environment. I'm getting following error:
>
> zopkio [ERROR] incorrect dir structure testfile:/tmp/samza-integraiton2/scripts/tests.py exist in same level as dir:/tmp/samza-integraiton2/scripts/tests
> Error in processing command line arguments:
> %s
Good catch. I was able to reproduce this. This is a new Zopkio feature. It's being more paranoid about module name conflicts.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/#review74096
-----------------------------------------------------------
On Feb. 23, 2015, 12:23 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31290/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 12:23 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMAZ-544
> https://issues.apache.org/jira/browse/SAMAZ-544
>
>
> Repository: samza
>
>
> Description
> -------
>
> recover test stateful task.
>
>
> remove trailing csv
>
>
> remove unit test. user proper constants. enable CMS for container performance test.
>
>
> delete unit test. add integration test.
>
>
> Diffs
> -----
>
> build.gradle b803276c13280ffed5ca1ce8ea608d81010e9b6b
> samza-test/src/main/config/perf/container-performance.properties PRE-CREATION
> samza-test/src/main/python/tests/performance_tests.py a97717fc8ecff4d2f8e0ea24ebe0636804f0fbd4
> samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala d589d762a18f9425aa8d8dd589011a151bcb59a4
>
> Diff: https://reviews.apache.org/r/31290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 31290: SAMAZ-544
Posted by Milinda Pathirage <mi...@apache.org>.
> On Feb. 25, 2015, 9:43 p.m., Milinda Pathirage wrote:
> > Ship It!
I think I found an issue. But I am not sure whether this is caused by my environment. I'm getting following error:
zopkio [ERROR] incorrect dir structure testfile:/tmp/samza-integraiton2/scripts/tests.py exist in same level as dir:/tmp/samza-integraiton2/scripts/tests
Error in processing command line arguments:
%s
- Milinda
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/#review74096
-----------------------------------------------------------
On Feb. 23, 2015, 12:23 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31290/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 12:23 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMAZ-544
> https://issues.apache.org/jira/browse/SAMAZ-544
>
>
> Repository: samza
>
>
> Description
> -------
>
> recover test stateful task.
>
>
> remove trailing csv
>
>
> remove unit test. user proper constants. enable CMS for container performance test.
>
>
> delete unit test. add integration test.
>
>
> Diffs
> -----
>
> build.gradle b803276c13280ffed5ca1ce8ea608d81010e9b6b
> samza-test/src/main/config/perf/container-performance.properties PRE-CREATION
> samza-test/src/main/python/tests/performance_tests.py a97717fc8ecff4d2f8e0ea24ebe0636804f0fbd4
> samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala d589d762a18f9425aa8d8dd589011a151bcb59a4
>
> Diff: https://reviews.apache.org/r/31290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 31290: SAMAZ-544
Posted by Milinda Pathirage <mi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/#review74096
-----------------------------------------------------------
Ship it!
Ship It!
- Milinda Pathirage
On Feb. 23, 2015, 12:23 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31290/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 12:23 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMAZ-544
> https://issues.apache.org/jira/browse/SAMAZ-544
>
>
> Repository: samza
>
>
> Description
> -------
>
> recover test stateful task.
>
>
> remove trailing csv
>
>
> remove unit test. user proper constants. enable CMS for container performance test.
>
>
> delete unit test. add integration test.
>
>
> Diffs
> -----
>
> build.gradle b803276c13280ffed5ca1ce8ea608d81010e9b6b
> samza-test/src/main/config/perf/container-performance.properties PRE-CREATION
> samza-test/src/main/python/tests/performance_tests.py a97717fc8ecff4d2f8e0ea24ebe0636804f0fbd4
> samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala d589d762a18f9425aa8d8dd589011a151bcb59a4
>
> Diff: https://reviews.apache.org/r/31290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 31290: SAMAZ-544
Posted by Naveen Somasundaram <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/#review73830
-----------------------------------------------------------
Ship it!
Ship It!
- Naveen Somasundaram
On Feb. 23, 2015, 12:23 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31290/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 12:23 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMAZ-544
> https://issues.apache.org/jira/browse/SAMAZ-544
>
>
> Repository: samza
>
>
> Description
> -------
>
> recover test stateful task.
>
>
> remove trailing csv
>
>
> remove unit test. user proper constants. enable CMS for container performance test.
>
>
> delete unit test. add integration test.
>
>
> Diffs
> -----
>
> build.gradle b803276c13280ffed5ca1ce8ea608d81010e9b6b
> samza-test/src/main/config/perf/container-performance.properties PRE-CREATION
> samza-test/src/main/python/tests/performance_tests.py a97717fc8ecff4d2f8e0ea24ebe0636804f0fbd4
> samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala d589d762a18f9425aa8d8dd589011a151bcb59a4
>
> Diff: https://reviews.apache.org/r/31290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 31290: SAMAZ-544
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31290/#review73828
-----------------------------------------------------------
Ship it!
- Chinmay Soman
On Feb. 23, 2015, 12:23 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31290/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 12:23 a.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMAZ-544
> https://issues.apache.org/jira/browse/SAMAZ-544
>
>
> Repository: samza
>
>
> Description
> -------
>
> recover test stateful task.
>
>
> remove trailing csv
>
>
> remove unit test. user proper constants. enable CMS for container performance test.
>
>
> delete unit test. add integration test.
>
>
> Diffs
> -----
>
> build.gradle b803276c13280ffed5ca1ce8ea608d81010e9b6b
> samza-test/src/main/config/perf/container-performance.properties PRE-CREATION
> samza-test/src/main/python/tests/performance_tests.py a97717fc8ecff4d2f8e0ea24ebe0636804f0fbd4
> samza-test/src/test/scala/org/apache/samza/test/performance/TestSamzaContainerPerformance.scala d589d762a18f9425aa8d8dd589011a151bcb59a4
>
> Diff: https://reviews.apache.org/r/31290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>