[GitHub] [calcite] amaliujia commented on a change in pull request #2308: [CALCITE-4450] ElasticSearch query with varchar literal projection fails with JsonParseException

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #2308:
URL: https://github.com/apache/calcite/pull/2308#discussion_r552309684



##########
File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchRules.java
##########
@@ -131,6 +131,10 @@ static String stripQuotes(String s) {
         ? s.substring(1, s.length() - 1) : s;
   }
 
+  private static String escapeSpecialSymbols(String s) {
+    return s.replace("\\", "\\\\").replace("\"", "\\\"");

Review comment:
       Question: is there other common case that needs to handled?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org