You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "bxfjb (via GitHub)" <gi...@apache.org> on 2024/11/15 01:51:30 UTC
[PR] [ISSUE #8927] Fix wrong queue offset of Lmq [rocketmq]
bxfjb opened a new pull request, #8928:
URL: https://github.com/apache/rocketmq/pull/8928
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #8927
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8927] DLedger support LMQ [rocketmq]
Posted by "bxfjb (via GitHub)" <gi...@apache.org>.
bxfjb commented on PR #8928:
URL: https://github.com/apache/rocketmq/pull/8928#issuecomment-2477890634
This pr is not finished yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8927] Fix wrong queue offset of Lmq [rocketmq]
Posted by "bxfjb (via GitHub)" <gi...@apache.org>.
bxfjb commented on PR #8928:
URL: https://github.com/apache/rocketmq/pull/8928#issuecomment-2477831558
@DongyuanPan Could yo review this pr pls, cause I"m not sure if I missed the update for your comment
`6 QUEUEOFFSET, need update later`
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8927] DLedger support LMQ [rocketmq]
Posted by "bxfjb (via GitHub)" <gi...@apache.org>.
bxfjb closed pull request #8928: [ISSUE #8927] DLedger support LMQ
URL: https://github.com/apache/rocketmq/pull/8928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8927] Fix wrong queue offset of Lmq [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8928:
URL: https://github.com/apache/rocketmq/pull/8928#issuecomment-2477820516
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8928?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 47.55%. Comparing base [(`60e68da`)](https://app.codecov.io/gh/apache/rocketmq/commit/60e68dadd9197730642ce55b1237e6f6f0401aa5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fef319f`)](https://app.codecov.io/gh/apache/rocketmq/commit/fef319fc22339af3462ae2889e7e6d7f2278c454?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8928 +/- ##
=============================================
- Coverage 47.62% 47.55% -0.07%
+ Complexity 11743 11731 -12
=============================================
Files 1304 1304
Lines 91058 91058
Branches 11675 11675
=============================================
- Hits 43362 43305 -57
- Misses 42352 42399 +47
- Partials 5344 5354 +10
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8928?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org