[GitHub] [doris] Gabriel39 commented on a diff in pull request #13362: [Enhancement](function) refactor of date function

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #13362:
URL: https://github.com/apache/doris/pull/13362#discussion_r995506834


##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -1040,6 +1039,8 @@ class DateV2Value {
         }
     }
 
+    bool is_valid_year() const { return year() < MAX_YEAR && year() > MIN_YEAR; }

Review Comment:
   unused function?



##########
be/src/vec/exec/format/parquet/vparquet_page_reader.cpp:
##########
@@ -19,6 +19,7 @@
 
 #include <stdint.h>
 
+#include "common/config.h"

Review Comment:
   unnecessary addition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org