[GitHub] [superset] diegomedina248 commented on a diff in pull request #19575: fix: Show full long number in text email report for table chart.

[GitBox <gi...@apache.org>]

diegomedina248 commented on code in PR #19575:
URL: https://github.com/apache/superset/pull/19575#discussion_r844342287


##########
superset/utils/csv.py:
##########
@@ -95,6 +98,9 @@ def get_chart_dataframe(
         return None
 
     result = simplejson.loads(content.decode("utf-8"))
+    pd.set_option(
+        "display.float_format", lambda x: str(x)
+    )  # need to convert float value to string to show full long number

Review Comment:
   add the comment above the line:
   ```
   # comm
   pd.set_option...
   ```



##########
superset/utils/csv.py:
##########
@@ -22,6 +23,8 @@
 import pandas as pd
 import simplejson
 
+logger = logging.getLogger(__name__)

Review Comment:
   this and the import is probably not needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org