You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/23 09:29:39 UTC
[GitHub] [pulsar] murong00 opened a new pull request #9683: [Spotbugs] Enable spotbugs for pulsar-io-kafka and pulsar-io-solr
murong00 opened a new pull request #9683:
URL: https://github.com/apache/pulsar/pull/9683
### Motivation
Enable spotbugs for the pulsar-io module.
### Modifications
Enable spotbugs for pulsar-io-kafka and pulsar-io-solr.
### Verifying this change
```
mvn clean install -pl pulsar-io/kafka
mvn clean install -pl pulsar-io/solr
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on a change in pull request #9683: [Spotbugs] Enable spotbugs for pulsar-io-kafka and pulsar-io-solr
Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #9683:
URL: https://github.com/apache/pulsar/pull/9683#discussion_r581509510
##########
File path: pulsar-io/kafka/pom.xml
##########
@@ -62,6 +62,23 @@
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-nar-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs-maven-plugin.version}</version>
Review comment:
done.
##########
File path: pulsar-io/solr/pom.xml
##########
@@ -80,6 +80,23 @@
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-nar-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs-maven-plugin.version}</version>
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9683: [Spotbugs] Enable spotbugs for pulsar-io-kafka and pulsar-io-solr
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9683:
URL: https://github.com/apache/pulsar/pull/9683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on pull request #9683: [Spotbugs] Enable spotbugs for pulsar-io-kafka and pulsar-io-solr
Posted by GitBox <gi...@apache.org>.
murong00 commented on pull request #9683:
URL: https://github.com/apache/pulsar/pull/9683#issuecomment-784712127
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9683: [Spotbugs] Enable spotbugs for pulsar-io-kafka and pulsar-io-solr
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9683:
URL: https://github.com/apache/pulsar/pull/9683#discussion_r581259277
##########
File path: pulsar-io/solr/pom.xml
##########
@@ -80,6 +80,23 @@
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-nar-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs-maven-plugin.version}</version>
Review comment:
Remove version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9683: [Spotbugs] Enable spotbugs for pulsar-io-kafka and pulsar-io-solr
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9683:
URL: https://github.com/apache/pulsar/pull/9683#discussion_r581258970
##########
File path: pulsar-io/kafka/pom.xml
##########
@@ -62,6 +62,23 @@
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-nar-maven-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs-maven-plugin.version}</version>
Review comment:
The version is already defined in the top level pom, this will print a maven warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org