You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by tv...@apache.org on 2012/02/19 17:18:25 UTC

svn commit: r1291019 - /openejb/trunk/openejb/tomee/tomee-webapp/src/main/webapp/staging/js/tomee/ApplicationChannel.js

Author: tveronezi
Date: Sun Feb 19 16:18:24 2012
New Revision: 1291019

URL: http://svn.apache.org/viewvc?rev=1291019&view=rev
Log:
https://issues.apache.org/jira/browse/TOMEE-130

Using "$.Callbacks()" instead of an array of callback methods.

Modified:
    openejb/trunk/openejb/tomee/tomee-webapp/src/main/webapp/staging/js/tomee/ApplicationChannel.js

Modified: openejb/trunk/openejb/tomee/tomee-webapp/src/main/webapp/staging/js/tomee/ApplicationChannel.js
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/tomee/tomee-webapp/src/main/webapp/staging/js/tomee/ApplicationChannel.js?rev=1291019&r1=1291018&r2=1291019&view=diff
==============================================================================
--- openejb/trunk/openejb/tomee/tomee-webapp/src/main/webapp/staging/js/tomee/ApplicationChannel.js (original)
+++ openejb/trunk/openejb/tomee/tomee-webapp/src/main/webapp/staging/js/tomee/ApplicationChannel.js Sun Feb 19 16:18:24 2012
@@ -40,12 +40,12 @@ TOMEE.ApplicationChannel = function (cfg
     var bind = function (messageKey, callback) {
         //avoiding "NullPointerException"
         if (!listeners[messageKey]) {
-            listeners[messageKey] = [];
+            listeners[messageKey] = $.Callbacks();
         }
 
         var myListeners = listeners[messageKey];
-        if (myListeners.indexOf(callback) < 0) {
-            myListeners.push(callback);
+        if (!myListeners.has(callback)) {
+            myListeners.add(callback);
         }
     };
 
@@ -61,10 +61,7 @@ TOMEE.ApplicationChannel = function (cfg
         }
 
         var myListeners = listeners[messageKey];
-        var index = myListeners.indexOf(callback);
-        if (index >= 0) {
-            myListeners.splice(index, 1);
-        }
+        myListeners.remove(callback);
     };
 
     /**
@@ -86,14 +83,8 @@ TOMEE.ApplicationChannel = function (cfg
             safeParamsObj = {};
         }
 
-        TOMEE.log.info("Message " + messageKey + " * " + myListeners.length);
-
-        for (var i = 0; i < myListeners.length; i++) {
-            (function (callback) {
-                callback(safeParamsObj);
-
-            })(myListeners[i]);
-        }
+        TOMEE.log.info("Message " + messageKey + ".");
+        myListeners.fire(safeParamsObj);
     };
 
     return {