You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eelco Hillenius (JIRA)" <ji...@apache.org> on 2011/01/21 23:51:46 UTC
[jira] Created: (WICKET-3363) forminput examle: switching locales
does not have the desired effect.
forminput examle: switching locales does not have the desired effect.
---------------------------------------------------------------------
Key: WICKET-3363
URL: https://issues.apache.org/jira/browse/WICKET-3363
Project: Wicket
Issue Type: Bug
Components: wicket-examples
Affects Versions: 1.5-RC1
Reporter: Eelco Hillenius
localization in the forminput example does not appear to be working. See: http://screencast.com/t/xxZFfUzi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3363) forminput examle: switching locales
does not have the desired effect.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3363:
---------------------------------------
Assignee: Martin Grigorov
> forminput examle: switching locales does not have the desired effect.
> ---------------------------------------------------------------------
>
> Key: WICKET-3363
> URL: https://issues.apache.org/jira/browse/WICKET-3363
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC1
> Reporter: Eelco Hillenius
> Assignee: Martin Grigorov
>
> localization in the forminput example does not appear to be working. See: http://screencast.com/t/xxZFfUzi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3363) forminput examle: switching locales
does not have the desired effect.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985134#action_12985134 ]
Martin Grigorov commented on WICKET-3363:
-----------------------------------------
With r1062172 the problem is fixed.
> forminput examle: switching locales does not have the desired effect.
> ---------------------------------------------------------------------
>
> Key: WICKET-3363
> URL: https://issues.apache.org/jira/browse/WICKET-3363
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC1
> Reporter: Eelco Hillenius
> Assignee: Martin Grigorov
>
> localization in the forminput example does not appear to be working. See: http://screencast.com/t/xxZFfUzi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3363) forminput examle: switching locales
does not have the desired effect.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3363:
---------------------------------------
Assignee: Igor Vaynberg (was: Martin Grigorov)
Igor, can you take a look at Url.java, line 780. It has the following code:
// process any ../ segments in the relative url
while (!relative.getSegments().isEmpty() && ("".equals(relative.getSegments().get(0))
I think this check for "" is wrong and should be removed.
I added the correct check for "..".
> forminput examle: switching locales does not have the desired effect.
> ---------------------------------------------------------------------
>
> Key: WICKET-3363
> URL: https://issues.apache.org/jira/browse/WICKET-3363
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC1
> Reporter: Eelco Hillenius
> Assignee: Igor Vaynberg
>
> localization in the forminput example does not appear to be working. See: http://screencast.com/t/xxZFfUzi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3363) forminput examle: switching locales
does not have the desired effect.
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985080#action_12985080 ]
Juergen Donnerstag commented on WICKET-3363:
--------------------------------------------
This is how it used to be (see http://www.wicket-library.com/wicket-examples/forminput/wicket/bookmarkable/org.apache.wicket.examples.forminput.FormInput?8)
<form class="inputForm" id="id1" method="post" action="wicket/page?6-7.IFormSubmitListener-inputForm"><div style="width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hidden"><input type="hidden" name="id1_hf_0" id="id1_hf_0" /></div>
<div>
Locale:
<select onchange="document.getElementById('id1_hf_0').value='./page?6-7.IOnChangeListener-inputForm-localeSelect';document.getElementById('id1').submit();" name="localeSelect">
<option selected="selected" value="0">Englisch</option>
And this is how it looks like now
<form class="inputForm" id="id22" method="post" action="../page?8-1.IFormSubmitListener-inputForm"><div style="width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hidden"><input type="hidden" name="id22_hf_0" id="id22_hf_0" /></div>
<div>
Locale:
<select onchange="document.getElementById('id22_hf_0').value='page?8-1.IOnChangeListener-inputForm-localeSelect';document.getElementById('id22').submit();" name="localeSelect">
<option value="0">Englisch</option>
There are obvious differences in form action which I think are ok, but also select onchange. These changes seem to cause the difference.
> forminput examle: switching locales does not have the desired effect.
> ---------------------------------------------------------------------
>
> Key: WICKET-3363
> URL: https://issues.apache.org/jira/browse/WICKET-3363
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC1
> Reporter: Eelco Hillenius
>
> localization in the forminput example does not appear to be working. See: http://screencast.com/t/xxZFfUzi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3363) forminput examle: switching locales
does not have the desired effect.
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3363.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC2
yeah, seems rather strange that it was checking for an empty string, i removed the old check.
> forminput examle: switching locales does not have the desired effect.
> ---------------------------------------------------------------------
>
> Key: WICKET-3363
> URL: https://issues.apache.org/jira/browse/WICKET-3363
> Project: Wicket
> Issue Type: Bug
> Components: wicket-examples
> Affects Versions: 1.5-RC1
> Reporter: Eelco Hillenius
> Assignee: Igor Vaynberg
> Fix For: 1.5-RC2
>
>
> localization in the forminput example does not appear to be working. See: http://screencast.com/t/xxZFfUzi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.