You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/03 10:30:48 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#5068: Enhance scaling write into proxy performance
KomachiSion opened a new pull request #5068: Enhance scaling write into proxy performance
URL: https://github.com/apache/incubator-shardingsphere/pull/5068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5068:
Enhance scaling write into proxy performance
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5068: Enhance scaling write into proxy performance
URL: https://github.com/apache/incubator-shardingsphere/pull/5068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5068:
Enhance scaling write into proxy performance
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5068: Enhance scaling write into proxy performance
URL: https://github.com/apache/incubator-shardingsphere/pull/5068#issuecomment-608385088
## Pull Request Test Coverage Report for [Build 10825](https://coveralls.io/builds/29821579)
* **7** of **11** **(63.64%)** changed or added relevant lines in **5** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.006%**) to **57.172%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/DistributionChannel.java](https://coveralls.io/builds/29821579/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FDistributionChannel.java#L106) | 0 | 1 | 0.0%
| [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29821579/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L83) | 0 | 1 | 0.0%
| [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/client/netty/MySQLBinlogEventPacketDecoder.java](https://coveralls.io/builds/29821579/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2Fclient%2Fnetty%2FMySQLBinlogEventPacketDecoder.java#L103) | 3 | 5 | 60.0%
<!-- | **Total:** | **7** | **11** | **63.64%** | -->
| Totals | [](https://coveralls.io/builds/29821579) |
| :-- | --: |
| Change from base [Build 10824](https://coveralls.io/builds/29821197): | 0.006% |
| Covered Lines: | 11710 |
| Relevant Lines: | 20482 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5068:
Enhance scaling write into proxy performance
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5068: Enhance scaling write into proxy performance
URL: https://github.com/apache/incubator-shardingsphere/pull/5068#issuecomment-608382914
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=h1) Report
> Merging [#5068](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/88e7be875752132f7d379ca8a3b8ddefb18822f3&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5068 +/- ##
=========================================
Coverage 53.79% 53.79%
Complexity 395 395
=========================================
Files 1151 1151
Lines 20477 20482 +5
Branches 3711 3713 +2
=========================================
+ Hits 11015 11019 +4
- Misses 8784 8785 +1
Partials 678 678
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../execute/executor/channel/DistributionChannel.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvY2hhbm5lbC9EaXN0cmlidXRpb25DaGFubmVsLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/core/execute/executor/channel/MemoryChannel.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvY2hhbm5lbC9NZW1vcnlDaGFubmVsLmphdmE=) | `40.74% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...phere/shardingscaling/mysql/MySQLBinlogReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvTXlTUUxCaW5sb2dSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...here/shardingscaling/mysql/client/MySQLClient.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L015U1FMQ2xpZW50LmphdmE=) | `61.72% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ket/binlog/row/MySQLBinlogTableMapEventPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L015U1FMQmlubG9nVGFibGVNYXBFdmVudFBhY2tldC5qYXZh) | `96.29% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ql/client/netty/MySQLBinlogEventPacketDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvY2xpZW50L25ldHR5L015U1FMQmlubG9nRXZlbnRQYWNrZXREZWNvZGVyLmphdmE=) | `95.06% <40.00%> (-1.15%)` | `0.00 <0.00> (ø)` | |
| [...aling/core/execute/executor/record/DataRecord.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvcmVjb3JkL0RhdGFSZWNvcmQuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=footer). Last update [88e7be8...39813c5](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5068?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services