You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 04:21:12 UTC

[GitHub] [pulsar] wuxuanqicn opened a new pull request, #16295: [Tests] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

wuxuanqicn opened a new pull request, #16295:
URL: https://github.com/apache/pulsar/pull/16295

   
   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   
   Fixes #15277
   
   
   ### Motivation
   
   
   State will be `Connecting` after `CommandCloseProducer` executed at client-side. Assert before execution cause the test to be flaky.
   
   ### Modifications
   
   await state become `Connecting`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- closed pull request #16295: [fix][test] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #16295: [fix][test] Fix flaky test ProducerCloseTest.brokerCloseTopicTest
URL: https://github.com/apache/pulsar/pull/16295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #16295: [Tests] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16295:
URL: https://github.com/apache/pulsar/pull/16295#issuecomment-1170739228

   @wuxuanqicn Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] wuxuanqicn closed pull request #16295: [fix][test] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

Posted by GitBox <gi...@apache.org>.
wuxuanqicn closed pull request #16295: [fix][test] Fix flaky test ProducerCloseTest.brokerCloseTopicTest
URL: https://github.com/apache/pulsar/pull/16295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] RobertIndie commented on pull request #16295: [Tests] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on PR #16295:
URL: https://github.com/apache/pulsar/pull/16295#issuecomment-1170762582

   PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- commented on pull request #16295: [fix][test] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #16295:
URL: https://github.com/apache/pulsar/pull/16295#issuecomment-1182995910

   Please rebase .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] wuxuanqicn commented on pull request #16295: [fix][test] Fix flaky test ProducerCloseTest.brokerCloseTopicTest

Posted by GitBox <gi...@apache.org>.
wuxuanqicn commented on PR #16295:
URL: https://github.com/apache/pulsar/pull/16295#issuecomment-1170794599

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org