You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dosubot[bot] (via GitHub)" <gi...@apache.org> on 2026/05/02 03:09:17 UTC
Re: [D] Refactor Pinot sqlglot dialect tests to use AST comparison instead of sub-string matching [superset]
GitHub user dosubot[bot] edited a comment on the discussion: Refactor Pinot sqlglot dialect tests to use AST comparison instead of sub-string matching
<!-- Greeting -->
Hi @0eu! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m helping the superset team.
<!-- Answer -->
Your proposal to refactor Pinot dialect tests to use AST comparison is a solid improvement. Current Pinot and other dialect tests in Superset rely on string-based assertions, which are brittle and sensitive to formatting or case changes, and there’s no established guidance or prior art for AST-based assertions in the codebase yet ([example](https://github.com/apache/superset/pull/35424), [example](https://github.com/apache/superset/blob/master/tests/unit_tests/sql/dialects/firebolt_tests.py)). AST comparison will make the tests more robust and focused on semantic correctness.
As you implement this, watch for dialect-specific constructs or sqlglot parsing limitations that might affect AST equivalence, and document any edge cases you find. In your PR, consider including examples where AST comparison clearly improves reliability over string matching, and explain the rationale for reviewers. This will help establish a strong precedent for future dialect test improvements.
If you run into tricky cases or want a second opinion on specific test conversions, feel free to ask!
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fsuperset).*
---
Docs are dead. Just use [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-tagline&utm_term=apache%2Fsuperset).
[](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-feedback&utm_term=apache%2Fsuperset&message_id=ab2eb21b-ac73-474c-9bb2-9e9e0b439feb) [](https://github.dosu.com/apache/superset?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-ask-repo&utm_term=apache%2Fsuperset) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-share-team&utm_term=apache%2Fsuperset)
GitHub link: https://github.com/apache/superset/discussions/36833#discussioncomment-15337792
----
This is an automatically sent email for notifications@superset.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@superset.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org