[GitHub] [phoenix] gjacoby126 commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747#discussion_r399897386
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
 ##########
 @@ -169,6 +171,48 @@ public void testDeleteNonExistingRow() throws Exception {
         }
     }
 
+    @Test
+    public void testIndexRowWithoutEmptyColumn() throws Exception {
+        if (async) {
+            // No need to run the same test twice one for async = true and the other for async = false
+            return;
+        }
+        long scn;
+        String dataTableName = generateUniqueName();
+        String indexTableName = generateUniqueName();
+        try (Connection conn = DriverManager.getConnection(getUrl())) {
+            populateTable(dataTableName); // with two rows ('a', 'ab', 'abc', 'abcd') and ('b', 'bc', 'bcd', 'bcde')
+            Thread.sleep(1000);
 
 Review comment:
   This can be done with EnvironmentEdgeManager rather than a sleep, and that's faster/safer than a sleep. Just remember to increment by at least one after any DDL or DML to be able to read it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services