You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by John Huss <jo...@gmail.com> on 2012/06/12 21:44:10 UTC

Inconsistent property name?

I'm updated my app to the most recent 3.1 and I think I found one property
name is wrong in org.apache.cayenne.configuration.Constants:

cayenne.rop.service.timeout

Seems to be inconsistent with the other properties, which all have an
underscore after "service", for example:

cayenne.rop.service_url

cayenne.rop.service_username

cayenne.rop.service_password


If that sounds right I will change it to use an underscore.

John

Re: Inconsistent property name?

Posted by Andrus Adamchik <an...@objectstyle.org>.
Yep.

On Jun 13, 2012, at 10:03 PM, John Huss wrote:

> So I need to change this in both branches (3.1 and 3.2), correct?
> 
> On Wed, Jun 13, 2012 at 1:32 AM, Andrus Adamchik <an...@objectstyle.org>wrote:
> 
>> 
>> On Jun 13, 2012, at 12:01 AM, John Huss wrote:
>> 
>>> I created the JIRA here:
>>> https://issues.apache.org/jira/browse/CAY-1713
>> 
>> Cool. With other comments in this thread, I am beginning to change my mind
>> :) ... maybe we indeed just do the simple thing - rename the property and
>> rely on this Jira mention in the release notes to notify the users.
>> 
>> Andrus


Re: Inconsistent property name?

Posted by John Huss <jo...@gmail.com>.
So I need to change this in both branches (3.1 and 3.2), correct?

On Wed, Jun 13, 2012 at 1:32 AM, Andrus Adamchik <an...@objectstyle.org>wrote:

>
> On Jun 13, 2012, at 12:01 AM, John Huss wrote:
>
> > I created the JIRA here:
> > https://issues.apache.org/jira/browse/CAY-1713
>
> Cool. With other comments in this thread, I am beginning to change my mind
> :) ... maybe we indeed just do the simple thing - rename the property and
> rely on this Jira mention in the release notes to notify the users.
>
> Andrus

Re: Inconsistent property name?

Posted by Andrus Adamchik <an...@objectstyle.org>.
On Jun 13, 2012, at 12:01 AM, John Huss wrote:

> I created the JIRA here:
> https://issues.apache.org/jira/browse/CAY-1713

Cool. With other comments in this thread, I am beginning to change my mind :) ... maybe we indeed just do the simple thing - rename the property and rely on this Jira mention in the release notes to notify the users.

Andrus

Re: Inconsistent property name?

Posted by John Huss <jo...@gmail.com>.
I created the JIRA here:
https://issues.apache.org/jira/browse/CAY-1713

Re: Inconsistent property name?

Posted by Mike Kienenberger <mk...@gmail.com>.
+1 for fixing the name and having the old synonym around.   Also +1
for just dropping the old name altogether.

On Tue, Jun 12, 2012 at 4:18 PM, Michael Gentry <mg...@masslight.net> wrote:
> Wouldn't it be harder (on us and users) to fix it later (3.2+) than now?
>
> mrg
>
> On Tue, Jun 12, 2012 at 4:12 PM, Andrus Adamchik <an...@objectstyle.org> wrote:
>> Ah good catch. You are absolutely right.
>>
>> One caveat though. Since we are in Beta now, we should follow our own self-imposed rules and avoid changing the API (property renaming being such a change IMO).
>>
>> I guess we can fix the String value for "ROP_SERVICE_TIMEOUT_PROPERTY" constant, but also keep the old value around as a deprecated "synonym". I.e. if a user defines a value for "cayenne.rop.service.timeout", we should load that into "cayenne.rop.service_timeout" internally. I know it is a pain...
>>
>> Should probably Jira that too so that it is recorded in RELEASE-NOTES.
>>
>> Andrus
>>
>>
>>
>> On Jun 12, 2012, at 10:44 PM, John Huss wrote:
>>
>>> I'm updated my app to the most recent 3.1 and I think I found one property
>>> name is wrong in org.apache.cayenne.configuration.Constants:
>>>
>>> cayenne.rop.service.timeout
>>>
>>> Seems to be inconsistent with the other properties, which all have an
>>> underscore after "service", for example:
>>>
>>> cayenne.rop.service_url
>>>
>>> cayenne.rop.service_username
>>>
>>> cayenne.rop.service_password
>>>
>>>
>>> If that sounds right I will change it to use an underscore.
>>>
>>> John
>>

Re: Inconsistent property name?

Posted by Michael Gentry <mg...@masslight.net>.
Wouldn't it be harder (on us and users) to fix it later (3.2+) than now?

mrg

On Tue, Jun 12, 2012 at 4:12 PM, Andrus Adamchik <an...@objectstyle.org> wrote:
> Ah good catch. You are absolutely right.
>
> One caveat though. Since we are in Beta now, we should follow our own self-imposed rules and avoid changing the API (property renaming being such a change IMO).
>
> I guess we can fix the String value for "ROP_SERVICE_TIMEOUT_PROPERTY" constant, but also keep the old value around as a deprecated "synonym". I.e. if a user defines a value for "cayenne.rop.service.timeout", we should load that into "cayenne.rop.service_timeout" internally. I know it is a pain...
>
> Should probably Jira that too so that it is recorded in RELEASE-NOTES.
>
> Andrus
>
>
>
> On Jun 12, 2012, at 10:44 PM, John Huss wrote:
>
>> I'm updated my app to the most recent 3.1 and I think I found one property
>> name is wrong in org.apache.cayenne.configuration.Constants:
>>
>> cayenne.rop.service.timeout
>>
>> Seems to be inconsistent with the other properties, which all have an
>> underscore after "service", for example:
>>
>> cayenne.rop.service_url
>>
>> cayenne.rop.service_username
>>
>> cayenne.rop.service_password
>>
>>
>> If that sounds right I will change it to use an underscore.
>>
>> John
>

Re: Inconsistent property name?

Posted by Andrus Adamchik <an...@objectstyle.org>.
Ah good catch. You are absolutely right.

One caveat though. Since we are in Beta now, we should follow our own self-imposed rules and avoid changing the API (property renaming being such a change IMO). 

I guess we can fix the String value for "ROP_SERVICE_TIMEOUT_PROPERTY" constant, but also keep the old value around as a deprecated "synonym". I.e. if a user defines a value for "cayenne.rop.service.timeout", we should load that into "cayenne.rop.service_timeout" internally. I know it is a pain...

Should probably Jira that too so that it is recorded in RELEASE-NOTES.

Andrus 



On Jun 12, 2012, at 10:44 PM, John Huss wrote:

> I'm updated my app to the most recent 3.1 and I think I found one property
> name is wrong in org.apache.cayenne.configuration.Constants:
> 
> cayenne.rop.service.timeout
> 
> Seems to be inconsistent with the other properties, which all have an
> underscore after "service", for example:
> 
> cayenne.rop.service_url
> 
> cayenne.rop.service_username
> 
> cayenne.rop.service_password
> 
> 
> If that sounds right I will change it to use an underscore.
> 
> John