You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/21 19:13:13 UTC
[GitHub] [solr] thelabdude opened a new pull request #299: SOLR-15637: Set .tls for security UI based on data.security.tls in response from server
thelabdude opened a new pull request #299:
URL: https://github.com/apache/solr/pull/299
https://issues.apache.org/jira/browse/SOLR-15637
Trivial UI fix. Tested manually, see screenshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #299: SOLR-15637: Set .tls for security UI based on data.security.tls in response from server
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #299:
URL: https://github.com/apache/solr/pull/299#issuecomment-924306638
<img width="404" alt="Screen Shot 2021-09-21 at 1 12 40 PM" src="https://user-images.githubusercontent.com/417074/134233228-8e0613a5-cf7d-452a-bacf-2ffc50f4419d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #299: SOLR-15637: Set scope.tls for security UI based on data.security.tls in response from server
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #299:
URL: https://github.com/apache/solr/pull/299#discussion_r713360046
##########
File path: solr/webapp/web/js/angular/controllers/security.js
##########
@@ -186,6 +187,7 @@ solrAdminApp.controller('SecurityController', function ($scope, $timeout, $cooki
$scope.permFilterTypes = ["", "name", "role", "path", "collection"];
System.get(function(data) {
+ $scope.tls = data.security ? data.security["tls"] : false;
Review comment:
*W069:* ['tls'] is better written in dot notation.
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude merged pull request #299: SOLR-15637: Set scope.tls for security UI based on data.security.tls in response from server
Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #299:
URL: https://github.com/apache/solr/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org