You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by lochiiconnectivity <gi...@git.apache.org> on 2016/07/13 00:05:29 UTC

[GitHub] libcloud pull request #840: [LIBCLOUD-836] Support Abiquo 3.4, remove deprec...

GitHub user lochiiconnectivity opened a pull request:

    https://github.com/apache/libcloud/pull/840

    [LIBCLOUD-836] Support Abiquo 3.4, remove deprecated attrs from VM model

    ## Support Abiquo 3.4, remove deprecated attrs from VM model
    
    ### Description
    
    As per JIRA, VM Model prior to Abiquo 3.4 specifies a size attribute 'hdInBytes', but this has not been used for some time (instead, HD size is automatically taken from the template), and it was deprecated from the VM model in 3.4 in favour of a disk node (see http://wiki.abiquo.com/display/ABI34/API+Changelog+v3.4)
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [X] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [X] Documentation
    - [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [X] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lochiiconnectivity/libcloud 836_abq34

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/840.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #840
    
----
commit 27ecfcdf679542cef544172828640e72469c8d94
Author: lochiiconnectivity <lc...@convergence.cx>
Date:   2016-07-13T00:02:13Z

    [LIBCLOUD-836] Support Abiquo 3.4, remove deprecated attrs from VM model

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #840: [LIBCLOUD-836] Support Abiquo 3.4, remove deprec...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/840


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---