You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2021/04/25 12:59:32 UTC
[kafka] branch trunk updated: KAFKA-10746: Change to Warn logs when
necessary to notify users (#9627)
This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new ea076a8 KAFKA-10746: Change to Warn logs when necessary to notify users (#9627)
ea076a8 is described below
commit ea076a8d6289fa8e94e7e6876437b565f9a9f9c3
Author: Luke Chen <43...@users.noreply.github.com>
AuthorDate: Sun Apr 25 20:55:10 2021 +0800
KAFKA-10746: Change to Warn logs when necessary to notify users (#9627)
Reviewers: A. Sophie Blee-Goldman <so...@confluent.io>, Chia-Ping Tsai <ch...@gmail.com>
---
.../clients/consumer/internals/AbstractCoordinator.java | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
index ba26427..cd1daa8 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
@@ -1023,6 +1023,10 @@ public abstract class AbstractCoordinator implements Closeable {
}
/**
+ * Sends LeaveGroupRequest and logs the {@code leaveReason}, unless this member is using static membership or is already
+ * not part of the group (ie does not have a valid member id, is in the UNJOINED state, or the coordinator is unknown).
+ *
+ * @param leaveReason the reason to leave the group for logging
* @throws KafkaException if the rebalance callback throws exception
*/
public synchronized RequestFuture<Void> maybeLeaveGroup(String leaveReason) {
@@ -1381,12 +1385,13 @@ public abstract class AbstractCoordinator implements Closeable {
} else if (heartbeat.pollTimeoutExpired(now)) {
// the poll timeout has expired, which means that the foreground thread has stalled
// in between calls to poll().
- String leaveReason = "consumer poll timeout has expired. This means the time between subsequent calls to poll() " +
- "was longer than the configured max.poll.interval.ms, which typically implies that " +
- "the poll loop is spending too much time processing messages. " +
- "You can address this either by increasing max.poll.interval.ms or by reducing " +
- "the maximum size of batches returned in poll() with max.poll.records.";
- maybeLeaveGroup(leaveReason);
+ log.warn("consumer poll timeout has expired. This means the time between subsequent calls to poll() " +
+ "was longer than the configured max.poll.interval.ms, which typically implies that " +
+ "the poll loop is spending too much time processing messages. You can address this " +
+ "either by increasing max.poll.interval.ms or by reducing the maximum size of batches " +
+ "returned in poll() with max.poll.records.");
+
+ maybeLeaveGroup("consumer poll timeout has expired.");
} else if (!heartbeat.shouldHeartbeat(now)) {
// poll again after waiting for the retry backoff in case the heartbeat failed or the
// coordinator disconnected