(superset) branch master updated: chore(internet_port): added new ports and removed unnecessary string class (#27078)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 3224ac1818 chore(internet_port): added new ports and removed unnecessary string class (#27078)
3224ac1818 is described below

commit 3224ac18185f7e8f6e7ce09898ce07620b86977d
Author: Anirudh Hegde <he...@gmail.com>
AuthorDate: Thu Feb 15 08:00:14 2024 +0530

    chore(internet_port): added new ports and removed unnecessary string class (#27078)
---
 superset/advanced_data_type/plugins/internet_port.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/superset/advanced_data_type/plugins/internet_port.py b/superset/advanced_data_type/plugins/internet_port.py
index 6776c7d0d2..3b2f8da7bb 100644
--- a/superset/advanced_data_type/plugins/internet_port.py
+++ b/superset/advanced_data_type/plugins/internet_port.py
@@ -48,6 +48,11 @@ port_conversion_dict: dict[str, list[int]] = {
     "ldaps": [636],
     "imap2": [143],  # aka imap
     "imaps": [993],
+    "MySQL": [3306],
+    "Remote Desktop": [3389],
+    "dns": [53],
+    "ctf": [84],
+    "pdap": [344],
 }
 
 
@@ -83,9 +88,9 @@ def port_translation_func(req: AdvancedDataTypeRequest) -> AdvancedDataTypeRespo
                 else port_conversion_dict[string_value]
             )
         except (KeyError, ValueError):
-            resp["error_message"] = str(
-                f"'{string_value}' does not appear to be a port name or number"
-            )
+            resp[
+                "error_message"
+            ] = f"'{string_value}' does not appear to be a port name or number"
             break
         else:
             resp["display_value"] = ", ".join(