You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/05/07 10:58:04 UTC

[GitHub] [cassandra] krummas commented on a change in pull request #555: CASSANDRA-15748 - injecting of parameters into IAuditLogger implementation

krummas commented on a change in pull request #555:
URL: https://github.com/apache/cassandra/pull/555#discussion_r421417541



##########
File path: src/java/org/apache/cassandra/audit/BinAuditLogger.java
##########
@@ -40,7 +41,7 @@
 
     private volatile BinLog binLog;
 
-    public BinAuditLogger()
+    public BinAuditLogger(Map<String, String> params)

Review comment:
       instead of adding this (most often) unused parameter, could we just grab the params from `DatabaseDescriptor.getAuditLoggingOptions().logger.parameters` in the constructor if we need them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org