You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:31:14 UTC

[GitHub] [beam] bullet03 opened a new pull request, #22468: [Website] update contribution content collapse

bullet03 opened a new pull request, #22468:
URL: https://github.com/apache/beam/pull/22468

   Content of Overview and Contribute Code sections was hiding on width between 640px and 768px. Contribute Code section didn't have a correct collalpse html structure.
   - fix Overview and Contribute Code sections, so content collapse works correctly on width 768px and lower
   - update related styles in _list.scss
   _________________________________________________________________________________________________________________________________
   before:
   ![collapse_before](https://user-images.githubusercontent.com/61748758/181235950-9bc2396d-49ce-457d-8de8-2b3578a2592f.gif)
   
   after:
   ![collapse_after_2](https://user-images.githubusercontent.com/61748758/181235999-2e7fa53d-2197-408f-8bcf-583d35a8bea7.gif)
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #22468:
URL: https://github.com/apache/beam/pull/22468#issuecomment-1210915874

   Sure! Please, don't forget to link it with a proper issue. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22468:
URL: https://github.com/apache/beam/pull/22468#issuecomment-1204907849

   @pcoet, could you kindly review current PR? It was tested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22468:
URL: https://github.com/apache/beam/pull/22468#issuecomment-1207961298

   > Thanks for finding and fixing this!
   
   Was glad tp help :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] alevtinaboiko commented on pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
alevtinaboiko commented on PR #22468:
URL: https://github.com/apache/beam/pull/22468#issuecomment-1200757865

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22468:
URL: https://github.com/apache/beam/pull/22468#issuecomment-1211655976

   > Sure! Please, don't forget to link it with a proper issue. Thanks
   
   Got it. Thank you for reminding and for the help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22468:
URL: https://github.com/apache/beam/pull/22468#issuecomment-1207959833

   @aromanenko-dev, this PR was approved. Could you, please, help with merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev merged pull request #22468: [Website] update contribution content collapse

Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #22468:
URL: https://github.com/apache/beam/pull/22468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org