You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/15 22:48:18 UTC
[GitHub] [incubator-nuttx] antmerlino opened a new pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
antmerlino opened a new pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730
## Summary
stm32h7 rcc: Sync h7x7xx and h7x3xx. Each of the differences is relevant to it's counterpart.
## Impact
Correct features supported on both platforms.
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#issuecomment-844952050
@btashton - Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on a change in pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
antmerlino commented on a change in pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#discussion_r633103855
##########
File path: arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
##########
@@ -473,6 +479,18 @@ static inline void rcc_enableapb2(void)
regval |= RCC_APB2ENR_SPI5EN;
#endif
+#ifdef CONFIG_STM32H7_USART1
+ /* USART1 clock enable */
+
+ regval |= RCC_APB2ENR_USART1EN;
+#endif
+
+#ifdef CONFIG_STM32H7_USART6
+ /* USART1 clock enable */
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on a change in pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
antmerlino commented on a change in pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#discussion_r633103567
##########
File path: arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
##########
@@ -826,8 +830,6 @@ void stm32_stdclockconfig(void)
regval |= STM32_PWR_CR3_LDOEN | STM32_PWR_CR3_LDOESCUEN;
putreg32(regval, STM32_PWR_CR3);
-#if 0
Review comment:
So I _think_ that the change directly below this was the reason it wasn't working. @davids5 fixed this in stm32h7x3xx_rcc.c after this was blocked out.
https://github.com/apache/incubator-nuttx/pull/3730/files#diff-60aa753b9f6076921466b4eda3676f762ea547fd270a563d5ca10b0d39204ef5R844
But yes, it would be good if you can validate this on hardware that you think once had the issue.
##########
File path: arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
##########
@@ -473,6 +479,18 @@ static inline void rcc_enableapb2(void)
regval |= RCC_APB2ENR_SPI5EN;
#endif
+#ifdef CONFIG_STM32H7_USART1
+ /* USART1 clock enable */
+
+ regval |= RCC_APB2ENR_USART1EN;
+#endif
+
+#ifdef CONFIG_STM32H7_USART6
+ /* USART1 clock enable */
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#discussion_r633059010
##########
File path: arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
##########
@@ -473,6 +479,18 @@ static inline void rcc_enableapb2(void)
regval |= RCC_APB2ENR_SPI5EN;
#endif
+#ifdef CONFIG_STM32H7_USART1
+ /* USART1 clock enable */
+
+ regval |= RCC_APB2ENR_USART1EN;
+#endif
+
+#ifdef CONFIG_STM32H7_USART6
+ /* USART1 clock enable */
Review comment:
typeo in comment: `USART6` not `USART1`
##########
File path: arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
##########
@@ -826,8 +830,6 @@ void stm32_stdclockconfig(void)
regval |= STM32_PWR_CR3_LDOEN | STM32_PWR_CR3_LDOESCUEN;
putreg32(regval, STM32_PWR_CR3);
-#if 0
Review comment:
I recall some boards having issues starting correctly with this. I need to check my boards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#issuecomment-844826342
@antmerlino @davids5 seems to be working on the hardware I had intermittent issues with previously so I will merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on a change in pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
antmerlino commented on a change in pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#discussion_r633103567
##########
File path: arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
##########
@@ -826,8 +830,6 @@ void stm32_stdclockconfig(void)
regval |= STM32_PWR_CR3_LDOEN | STM32_PWR_CR3_LDOESCUEN;
putreg32(regval, STM32_PWR_CR3);
-#if 0
Review comment:
So I _think_ that the change directly below this was the reason it wasn't working. @davids5 fixed this in stm32h7x3xx_rcc.c after this was blocked out.
https://github.com/apache/incubator-nuttx/pull/3730/files#diff-60aa753b9f6076921466b4eda3676f762ea547fd270a563d5ca10b0d39204ef5R844
But yes, it would be good if you can validate this on hardware that you think once had the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #3730: stm32h7 rcc: Sync h7x7xx and h7x3xx. Changes are relevant to both
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #3730:
URL: https://github.com/apache/incubator-nuttx/pull/3730#discussion_r633059010
##########
File path: arch/arm/src/stm32h7/stm32h7x3xx_rcc.c
##########
@@ -473,6 +479,18 @@ static inline void rcc_enableapb2(void)
regval |= RCC_APB2ENR_SPI5EN;
#endif
+#ifdef CONFIG_STM32H7_USART1
+ /* USART1 clock enable */
+
+ regval |= RCC_APB2ENR_USART1EN;
+#endif
+
+#ifdef CONFIG_STM32H7_USART6
+ /* USART1 clock enable */
Review comment:
typeo in comment: `USART6` not `USART1`
##########
File path: arch/arm/src/stm32h7/stm32h7x7xx_rcc.c
##########
@@ -826,8 +830,6 @@ void stm32_stdclockconfig(void)
regval |= STM32_PWR_CR3_LDOEN | STM32_PWR_CR3_LDOESCUEN;
putreg32(regval, STM32_PWR_CR3);
-#if 0
Review comment:
I recall some boards having issues starting correctly with this. I need to check my boards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org