You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/16 04:39:20 UTC

[GitHub] [beam] amaliujia commented on a change in pull request #13912: [BEAM-11747] Reject the mixed Java UDF and ZetaSQL builtin operator cases

amaliujia commented on a change in pull request #13912:
URL: https://github.com/apache/beam/pull/13912#discussion_r576544484



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -116,8 +116,43 @@ public QueryPlanner createPlanner(
     return modifyRuleSetsForZetaSql(BeamRuleSets.getRuleSets());
   }
 
-  /** Returns true if the argument contains any user-defined Java functions. */
-  static boolean hasUdfInProjects(RelOptRuleCall x) {
+  /**
+   * Returns true if the arguments only contain any user-defined Java functions, otherwise returns

Review comment:
       Added to comment to clarify what is user-defined java functions. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org