You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/21 22:23:38 UTC
[GitHub] [zookeeper] suhasdantkale opened a new pull request #1259:
ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS
does not resolve one of the servers in the zk ensemble
suhasdantkale opened a new pull request #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259
The change is backported from
Jeelani Mohamed Abdul Khader <mj...@devvm3360.prn2.facebook.com>'s
https://github.com/apache/zookeeper/pull/579 change done in
"ZOOKEEPER-3095: Connect string fix for non-existent hosts"
Code changes to not fail the session initiation if the DNS is not able to
resolve the hostname of one of the servers in the Zookeeper ensemble.
Some Background:
The Zookeeper client resolves all the hostnames in the ensemble while establishing the session.
In Kubernetes environment with coreDNS, the hostname entry gets removed from coreDNS during the POD restarts.
Though we can manipulate the coreDNS settings to delay the removal of the hostname entry from DNS,
we don't want to leave any race where Zookeeper client is trying to establish a session and it fails
because the DNS temporarily is not able to resolve the hostname. So as long as one of the servers
in the ensemble is able to be DNS resolvable, should we not fail the session establishment with hard error
and instead try to establish the connection with one of the other servers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] suhasdantkale commented on issue #1259: ZOOKEEPER-3723
Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve
one of the servers in the zk ensemble
Posted by GitBox <gi...@apache.org>.
suhasdantkale commented on issue #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259#issuecomment-589863388
@anmolnar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1259: ZOOKEEPER-3723
Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve
one of the servers in the zk ensemble
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259#issuecomment-590704755
That page is out dated, now with github tests have been already executed and they passed.
You only need two sponsors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1259: ZOOKEEPER-3723
Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve
one of the servers in the zk ensemble
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259#issuecomment-590704310
We are strictly following review-then-commit.
In order to commit a (non trivial) patch we wait for at least two 'binding' approvals, that is by two committers (people with write access to the repository).
Thanks for your contribution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] symat commented on issue #1259: ZOOKEEPER-3723
Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve
one of the servers in the zk ensemble
Posted by GitBox <gi...@apache.org>.
symat commented on issue #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259#issuecomment-590204952
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] suhasdantkale commented on issue #1259: ZOOKEEPER-3723
Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve
one of the servers in the zk ensemble
Posted by GitBox <gi...@apache.org>.
suhasdantkale commented on issue #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259#issuecomment-590582787
Hi Mate (@symat),
How generally contributor should proceed after the Review is approved?
As per this document -
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
"Code Review and Accept Pull Request
Once a "+1" comment is received from the automated patch testing system and a code reviewer has set the Reviewed flag on the issue's Jira, a committer should then evaluate it within a few days and either: commit it; or reject it with an explanation."
When does the the automated patch testing system sends its comments?
Sorry to bother you with these basic queries. Please point me that if there is any other document that has these details?
Regards,
Suhas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] suhasdantkale commented on issue #1259: ZOOKEEPER-3723
Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve
one of the servers in the zk ensemble
Posted by GitBox <gi...@apache.org>.
suhasdantkale commented on issue #1259: ZOOKEEPER-3723 Zookeeper Client should not fail with ZSYSTEMERROR if DNS does not resolve one of the servers in the zk ensemble
URL: https://github.com/apache/zookeeper/pull/1259#issuecomment-589863220
@mjeelanimsft
@symat
Can you please review the changes?
The change is backported from :
Jeelani Mohamed Abdul Khader mjeelani@devvm3360.prn2.facebook.com's
"ZOOKEEPER-3095: Connect string fix for non-existent hosts"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services