[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2649: MINOR: Implement serde for join filter

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2649:
URL: https://github.com/apache/arrow-datafusion/pull/2649#discussion_r884339816


##########
datafusion/proto/src/logical_plan.rs:
##########
@@ -605,6 +605,11 @@ impl AsLogicalPlan for LogicalPlanNode {
                         join.join_constraint
                     ))
                 })?;
+                let filter: Option<Expr> = join
+                    .filter
+                    .as_ref()
+                    .map(|expr| parse_expr(expr, ctx))
+                    .map_or(Ok(None), |v| v.map(Some))?;

Review Comment:
   Maybe https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose ? I'm having a hard time figuring out what the types are though so could be mistaken



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org