You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/07/15 12:58:08 UTC
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
lipenglin@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18735
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
The DESCRIBE FORMATTED output show this even for bucketed Iceberg
tables:
| Num Buckets: | 0 | NULL |
| Bucket Columns: | [] | NULL |
We should remove them, and the user should rely on the information in
the '# Partition Transform Information' block instead.
Testing:
- add e2e tests
- tested in a real cluster
Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 21 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/18735/4
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10976/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:18:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 4: Code-Review+2
Thanks for fixing this! LGTM!
FYI: I'll be on vacation on the next 2 weeks, but feel free to ask the other folks (especially Gabor, Tamas, Gergely) to review your changes.
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:29:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
The DESCRIBE FORMATTED output show this even for bucketed Iceberg
tables:
| Num Buckets: | 0 | NULL |
| Bucket Columns: | [] | NULL |
We should remove them, and the user should rely on the information in
the '# Partition Transform Information' block instead.
Testing:
- add e2e tests
- tested in a real cluster
Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Reviewed-on: http://gerrit.cloudera.org:8080/18735
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/HiveMetadataFormatUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
2 files changed, 21 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Jul 2022 08:02:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:29:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8319/
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 18:20:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8319/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jul 2022 13:29:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18735 )
Change subject: IMPALA-11433: Remove misleading bucketing info from DESCRIBE FORMATTED output for Iceberg tables
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8324/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc156c932780f0f12c935a1a60ff6606d59bb1da
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Jul 2022 03:11:16 +0000
Gerrit-HasComments: No