You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/06 05:11:15 UTC
[GitHub] [netbeans] lbownik opened a new pull request, #4081: improved tests for MapFormat
lbownik opened a new pull request, #4081:
URL: https://github.com/apache/netbeans/pull/4081
improved tests for MapFormat
refactored MapFormat.format, works 2x faster and generated about 50x less garbage
removed public method MapFormat.processPattern - it was not used and considering it's functionality must have been made public by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #4081: improved tests for MapFormat
Posted by GitBox <gi...@apache.org>.
vieiro commented on PR #4081:
URL: https://github.com/apache/netbeans/pull/4081#issuecomment-1120367681
Discussions about API changes are to be carried out in the mailing lists, with a broader audience, not in pull requests. Pull requests are expected to contain fixes and enhancements, not discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on pull request #4081: improved tests for MapFormat
Posted by GitBox <gi...@apache.org>.
lbownik commented on PR #4081:
URL: https://github.com/apache/netbeans/pull/4081#issuecomment-1120242851
> We have already explained in the mailing lists that you cannot change a public API of a module.
my reasoning is the following (based on original implementation)
- "procesPattern" is never called by any client within code base;
- calling "processPattern" by clients is useless because:
- it mainly prepares internal state for execution of "format", which then gets overwritten anyway, since "format" calls "preparePattern" enyway overwriting effects of previous execution, which makes calling "processPattern" by client a no-op;
- "processPattern" returns the original pattern string with steering sequences stripped, so giving it "Hello {name}!" will return "Hello !" - which seems useless for clients;
So I suspect that the propability of any client calling this method is 0. I suspect that this pethod intention was to be private but it was made public by accident (it was probably made public temporarily for testing purposes during developement and then stayed like this).
But.. If we want to keep this API structure unchanged then I could provide a stubbed implementation like
@Deprecated
public String processPattern(String newPattern) throws IllegalArgumentException {
return newPattern;
}
would it be acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik closed pull request #4081: improved tests for MapFormat
Posted by GitBox <gi...@apache.org>.
lbownik closed pull request #4081: improved tests for MapFormat
URL: https://github.com/apache/netbeans/pull/4081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists