You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by nwellnhof <gi...@git.apache.org> on 2016/04/06 13:46:31 UTC
[lucy-dev] [GitHub] lucy-clownfish pull request: Fix unsafe usage of ctype.h functions
GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy-clownfish/pull/65
Fix unsafe usage of ctype.h functions
Fixes CLOWNFISH-90.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy-clownfish ctype-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit fb28c3c8c707a6c289553a7480922134bfb0e110
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-04-06T11:03:44Z
Add safe ctype.h wrappers
From the C99 spec:
The header <ctype.h> declares several functions useful for
classifying and mapping characters. In all cases the argument is an
int, the value of which shall be representable as an unsigned char
or shall equal the value of the macro EOF. If the argument has any
other value, the behavior is undefined.
The behavior of these functions is affected by the current locale.
Implementations using a superset of ASCII are assumed.
commit a6bfd289edd6dba8cd73aed9b655fd56ae52b20b
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-04-06T11:24:36Z
Switch to safe ctype.h wrappers
commit 8e136edacf5e531101e8bbf165fe7a8b1e005264
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-04-06T11:29:23Z
Check code point range in Str_BaseX_To_I64
Avoid undefined behavior when calling ctype.h functions.
commit 2fda55327d59ec11b88ce1056e91b46e833ff406
Author: Nick Wellnhofer <we...@aevum.de>
Date: 2016-04-06T11:31:30Z
Remove unneeded ctype.h includes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[lucy-dev] [GitHub] lucy-clownfish pull request: Fix unsafe usage of ctype.h functions
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy-clownfish/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---