[jira] [Resolved] (SOLR-14579) Comment SolrJ 'Utils' generic map functions

["Erick Erickson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson resolved SOLR-14579.
-----------------------------------
    Fix Version/s:     (was: master (9.0))
                   8.7
       Resolution: Fixed

A funny thing happened on the way to working on this... most of the non-lambda changes were in autoscaling, which is gone. After that, when I did _not_ change the lambdas, all that was left was some unnecessary SuppressWarnings it utils.

Still, I thought it would be useful to go ahead and add Noble's comments about why the static lambdas were used so I went ahead and did that.

There would up being _no_ code changes.

[~megancarey] Many thanks for working on this, it's especially useful that I think we all have a little better understanding on why the lambdas are used the way they are.

> Comment SolrJ 'Utils' generic map functions
> -------------------------------------------
>
>                 Key: SOLR-14579
>                 URL: https://issues.apache.org/jira/browse/SOLR-14579
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: master (9.0)
>            Reporter: Megan Carey
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 8.7
>
>         Attachments: SOLR-14579.patch
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Remove the map functions like `NEW_HASHMAP_FUN` from the Utils class in solrj module to reduce warnings and improve code quality.
> [https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Utils.java#L92]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org