[GitHub] [superset] diegomedina248 commented on a diff in pull request #19244: fix: Add database search in available charts on dashboard.

[GitBox <gi...@apache.org>]

diegomedina248 commented on code in PR #19244:
URL: https://github.com/apache/superset/pull/19244#discussion_r849595701


##########
superset-frontend/src/dashboard/actions/sliceEntities.js:
##########
@@ -39,92 +39,154 @@ export function fetchAllSlicesFailed(error) {
   return { type: FETCH_ALL_SLICES_FAILED, payload: { error } };
 }
 
+function fetchSlices(
+  userId,
+  excludeFilterBox,
+  dispatch,

Review Comment:
   you could transform this to an action creator function (like the ones below) to avoid passing this param around



##########
superset-frontend/src/dashboard/actions/sliceEntities.js:
##########
@@ -39,92 +39,154 @@ export function fetchAllSlicesFailed(error) {
   return { type: FETCH_ALL_SLICES_FAILED, payload: { error } };
 }
 
+function fetchSlices(
+  userId,
+  excludeFilterBox,
+  dispatch,
+  filter_value,
+  sortColumn = 'changed_on_delta_humanized',
+  slices = {}

Review Comment:
   do you need the current slices? aren't we fetching here and need to replace the existing ones?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org