You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/04/12 06:32:30 UTC

[GitHub] [avro] opwvhk commented on a diff in pull request #1639: AVRO-3482: Reuse MAGIC in DataFileReader

opwvhk commented on code in PR #1639:
URL: https://github.com/apache/avro/pull/1639#discussion_r848022929


##########
lang/java/avro/src/main/java/org/apache/avro/file/DataFileReader.java:
##########
@@ -69,10 +69,9 @@ public static <D> FileReader<D> openReader(SeekableInput in, DatumReader<D> read
       length -= bytesRead;
       offset += bytesRead;
     }
-    in.seek(0);
 
     if (Arrays.equals(MAGIC, magic)) // current format
-      return new DataFileReader<>(in, reader);
+      return newreturn new DataFileReader<>(in, reader, magic);

Review Comment:
   What is the purpose of `newreturn`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org