You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2020/02/26 02:40:44 UTC
[kudu-CR] [ycm] Support recent versions of YouCompleteMe
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15296
Change subject: [ycm] Support recent versions of YouCompleteMe
......................................................................
[ycm] Support recent versions of YouCompleteMe
The Vim plugin YouCompleteMe now looks for a Settings() method in the
.ycm_extra_conf.py file instead of FlagsForFile(). According to some bug
reports I saw, they claim to be backwards-compatible, but that wasn't my
experience using --clang-completer. This patch just adds a Settings()
call that invokes FlagsForFile(), and leaves FlagsForFile() in place for
backcompat with older versions of YCM. This works for me on the latest
master version of YCM.
Change-Id: I21cc5e2cf05f91c1a6ed44cfbacc5b325438f5b7
---
M .ycm_extra_conf.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/15296/1
--
To view, visit http://gerrit.cloudera.org:8080/15296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21cc5e2cf05f91c1a6ed44cfbacc5b325438f5b7
Gerrit-Change-Number: 15296
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] [ycm] Support recent versions of YouCompleteMe
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15296 )
Change subject: [ycm] Support recent versions of YouCompleteMe
......................................................................
[ycm] Support recent versions of YouCompleteMe
The Vim plugin YouCompleteMe now looks for a Settings() method in the
.ycm_extra_conf.py file instead of FlagsForFile(). According to some bug
reports I saw, they claim to be backwards-compatible, but that wasn't my
experience using --clang-completer. This patch just adds a Settings()
call that invokes FlagsForFile(), and leaves FlagsForFile() in place for
backcompat with older versions of YCM. This works for me on the latest
master version of YCM.
Change-Id: I21cc5e2cf05f91c1a6ed44cfbacc5b325438f5b7
Reviewed-on: http://gerrit.cloudera.org:8080/15296
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M .ycm_extra_conf.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I21cc5e2cf05f91c1a6ed44cfbacc5b325438f5b7
Gerrit-Change-Number: 15296
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [ycm] Support recent versions of YouCompleteMe
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15296 )
Change subject: [ycm] Support recent versions of YouCompleteMe
......................................................................
Patch Set 2:
> Welcome back!
Thanks Adar! And thanks for the quick review!
--
To view, visit http://gerrit.cloudera.org:8080/15296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21cc5e2cf05f91c1a6ed44cfbacc5b325438f5b7
Gerrit-Change-Number: 15296
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Feb 2020 19:19:04 +0000
Gerrit-HasComments: No
[kudu-CR] [ycm] Support recent versions of YouCompleteMe
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15296 )
Change subject: [ycm] Support recent versions of YouCompleteMe
......................................................................
Patch Set 1: Code-Review+2
Welcome back!
--
To view, visit http://gerrit.cloudera.org:8080/15296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21cc5e2cf05f91c1a6ed44cfbacc5b325438f5b7
Gerrit-Change-Number: 15296
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Feb 2020 19:15:43 +0000
Gerrit-HasComments: No