[GitHub] [shiro] bmarwell commented on a change in pull request #314: [SHIRO-802] expect running ITs, create profile for ITs.

[GitBox <gi...@apache.org>]

bmarwell commented on a change in pull request #314:
URL: https://github.com/apache/shiro/pull/314#discussion_r681533326



##########
File path: .github/pull_request_template.md
##########
@@ -13,8 +13,9 @@ Following this checklist to help us incorporate your contribution quickly and ea
        where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
        is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] Run `mvn clean verify apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. 
+ - [ ] (Optional) run `mvn verify -Pdocs,ci` to verify all tests pass. 

Review comment:
       run-its is missing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org