[GitHub] [openwhisk-runtime-dotnet] kamyker edited a comment on issue #26: Raw requests to skip JObject conversion

[GitBox <gi...@apache.org>]

kamyker edited a comment on issue #26: Raw requests to skip JObject conversion
URL: https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-559576862
 
 
   Not sure how exactly AWS (from what I read they expose Stream to their [APIGatewayProxyRequest.cs](https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.APIGatewayEvents/APIGatewayProxyRequest.cs)) Tried Azure and they expose full HttpRequest ([docs](https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-http-webhook?tabs=csharp)) . 
   
   I dislike automatic object conversion as it will use predefined serializer and instead prefer having raw data and do custom (and faster) deserialization. Using other providers that do it I also found it annoying and confusing when any exceptions happen outside my code and sometimes was unable to debug without me deploying whole local runtime solution.
   
   > I don't think we would want the full raw request stream going to the client.
   Exactly what I'd like as it's simplest and fastest(?) solution. Raw body of the request stream.
   
   How important are these lines? https://github.com/apache/openwhisk-runtime-dotnet/blob/c73dae10ab7538e5b3110158427f8ae5e6fbd399/core/dotnet2.2/proxy/Apache.OpenWhisk.Runtime.Common/Run.cs#L50-L76
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services