You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/21 20:39:00 UTC
[jira] [Work logged] (BEAM-14351) Example 'JsonCoder' object has no attribute 'to_type_hint'
[ https://issues.apache.org/jira/browse/BEAM-14351?focusedWorklogId=760403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760403 ]
ASF GitHub Bot logged work on BEAM-14351:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 20:38
Start Date: 21/Apr/22 20:38
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17437:
URL: https://github.com/apache/beam/pull/17437#issuecomment-1105735470
# [Codecov](https://codecov.io/gh/apache/beam/pull/17437?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17437](https://codecov.io/gh/apache/beam/pull/17437?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7152cc8) into [master](https://codecov.io/gh/apache/beam/commit/a64572ea68d8f33cfccc894f8b204ece93e20fb6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a64572e) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #17437 +/- ##
==========================================
- Coverage 73.81% 73.81% -0.01%
==========================================
Files 687 687
Lines 90329 90330 +1
==========================================
- Hits 66677 66676 -1
- Misses 22470 22472 +2
Partials 1182 1182
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.62% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/exec/fn.go](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9mbi5nbw==) | `55.55% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/core/runtime/exec/fn\_arity.go](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9mbl9hcml0eS5nbw==) | `6.47% <ø> (ø)` | |
| [...dks/python/apache\_beam/examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svY29kZXJzLnB5) | `63.15% <100.00%> (+0.99%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.25% <0.00%> (-0.81%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.26% <0.00%> (-0.25%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `88.90% <0.00%> (+0.47%)` | :arrow_up: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/17437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `79.71% <0.00%> (+2.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17437?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17437?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f44566...7152cc8](https://codecov.io/gh/apache/beam/pull/17437?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 760403)
Remaining Estimate: 0h
Time Spent: 10m
> Example 'JsonCoder' object has no attribute 'to_type_hint'
> ----------------------------------------------------------
>
> Key: BEAM-14351
> URL: https://issues.apache.org/jira/browse/BEAM-14351
> Project: Beam
> Issue Type: Bug
> Components: examples-python
> Reporter: Andrew Pilloud
> Assignee: Robert Bradshaw
> Priority: P1
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This test wasn't running due to BEAM-14336, I'm not sure it ever ran successfully. It is a hard failure in beam_PostCommit_Python_Examples_Dataflow apache_beam.examples.cookbook.coders_it_test.CodersIT.test_coders_output_files_on_small_input:
> https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Dataflow/293/testReport/junit/apache_beam.examples.cookbook.coders_it_test/CodersIT/test_coders_output_files_on_small_input/
> {code}
> self = <apache_beam.examples.cookbook.coders_it_test.CodersIT testMethod=test_coders_output_files_on_small_input>
> @pytest.mark.no_xdist
> @pytest.mark.examples_postcommit
> def test_coders_output_files_on_small_input(self):
> test_pipeline = TestPipeline(is_integration_test=True)
> # Setup the files with expected content.
> OUTPUT_FILE_DIR = \
> 'gs://temp-storage-for-end-to-end-tests/py-it-cloud/output'
> output = '/'.join([OUTPUT_FILE_DIR, str(uuid.uuid4()), 'result'])
> INPUT_FILE_DIR = \
> 'gs://temp-storage-for-end-to-end-tests/py-it-cloud/input'
> input = '/'.join([INPUT_FILE_DIR, str(uuid.uuid4()), 'input.txt'])
> create_content_input_file(
> input, '\n'.join(map(json.dumps, self.SAMPLE_RECORDS)))
> extra_opts = {'input': input, 'output': output}
> > coders.run(test_pipeline.get_full_options_as_args(**extra_opts))
> apache_beam/examples/cookbook/coders_it_test.py:93:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> apache_beam/examples/cookbook/coders.py:87: in run
> p
> apache_beam/transforms/ptransform.py:1092: in __ror__
> return self.transform.__ror__(pvalueish, self.label)
> apache_beam/transforms/ptransform.py:614: in __ror__
> result = p.apply(self, pvalueish, label)
> apache_beam/pipeline.py:662: in apply
> return self.apply(transform, pvalueish)
> apache_beam/pipeline.py:708: in apply
> pvalueish_result = self.runner.apply(transform, pvalueish, self._options)
> apache_beam/runners/dataflow/dataflow_runner.py:141: in apply
> return super().apply(transform, input, options)
> apache_beam/runners/runner.py:185: in apply
> return m(transform, input, options)
> apache_beam/runners/runner.py:215: in apply_PTransform
> return transform.expand(input)
> apache_beam/io/textio.py:690: in expand
> self._source.output_type_hint())
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> self = <apache_beam.io.textio._TextSource object at 0x7fef4d8071c0>
> def output_type_hint(self):
> try:
> > return self._coder.to_type_hint()
> E AttributeError: 'JsonCoder' object has no attribute 'to_type_hint'
> apache_beam/io/textio.py:409: AttributeError
> {code}
> cc: [~tvalentyn]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)